Skip to content

Conversation

bmagistro
Copy link
Contributor

When compiling with clang 19.1.7 on Alma with -Werror and a number of other flags (we run with most warnings enabled), the lines were flagged with error: use of old-style cast [-Werror, -Wold-style-cast]. It is unclear if this was just missed or cast style was not updated. Additionally, 0 was switched to nullptr for improved clarity in these lines.

The updates here were found in conjunction with boostorg/function#55.

Env:
Alma 9.6
Boost 1.88.0 via cmake
clang 19.1.7

Signed-off-by: Ben Magistro <[email protected]>
@vprus
Copy link
Collaborator

vprus commented Aug 19, 2025

Thanks for the PR.

Tehnically, the use of nullptr is a C++11 feature, but apparently shared_ptr now requires a C++11 compiler, so program_options would not build with C++03 anyway.

@vprus vprus merged commit 18e51b7 into boostorg:develop Aug 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants