Skip to content

Conversation

@danielballan
Copy link
Member

@danielballan danielballan commented Aug 20, 2025

An xfail-ed tests caused us to miss a regression. When the MongoAdapter is configured with an access policy (authz_shim), updating metadata raised an error. This PR includes a unit test that reproduced the error:

FAILED databroker/tests/test_broker.py::test_update[mongo-tiled-False] - NotImplementedError: Updating access_blob on MongoDB-backed data is not supported.
FAILED databroker/tests/test_broker.py::test_update[mongo-tiled-True] - NotImplementedError: Updating access_blob on MongoDB-backed data is not supported.

and then a commit with a fix.

It also fixes the confusing mistake within the test itself, which seems to be the that caused us to xfail this test in the first place.

@danielballan
Copy link
Member Author

Test failures...

FAILED databroker/tests/test_broker.py::test_fill_and_multiple_streams[sqlite-tiled-False] - KeyError: 'detfs2'
FAILED databroker/tests/test_broker.py::test_fill_and_multiple_streams[sqlite-tiled-True] - KeyError: 'detfs2'
= 2 failed, 765 passed, 92 skipped, 8 deselected, 47 xfailed, 26 xpassed, 60 warnings in 557.56s (0:09:17) =

are due to a known regression in bluesky, fixed in bluesky/bluesky#1942 but not yet released.

Copy link
Contributor

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the failures in CI are not related to this newly included test.

@maffettone maffettone merged commit 863cfd7 into bluesky:main Aug 20, 2025
6 of 10 checks passed
@danielballan danielballan deleted the update-metadata-fixup branch August 20, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants