Mod Presets: Revamp death sound options#5616
Open
exurd wants to merge 1 commit intobloxstraplabs:mainfrom
Open
Mod Presets: Revamp death sound options#5616exurd wants to merge 1 commit intobloxstraplabs:mainfrom
exurd wants to merge 1 commit intobloxstraplabs:mainfrom
Conversation
his mother must be very proud, huh?
ghost
mentioned this pull request
1 task
Author
|
@pizzaboxer @bluepilledgreat Following v2.10.0, is this PR currently unwarranted/unneeded? Please respond as soon as you can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the OOF sound was officially put back into the game, the option to bring back the sound is now moot. This PR revamps this option by being able to switch back to the 2022 sound or the unused sound (Kid saying Ouch.wav). Both of these sounds were sourced from the Creator Store, Ogg format.
Some notes:
OldDeathSound_DescriptionandOldDeathSound_Titlestrings have been replaced withCustomDeathSound_*, and there are three strings forEnums.DeathSound. New translations will need to be created for these strings.