Conversation
… initing/ready status (closes #608)
g11tech
approved these changes
Mar 3, 2026
…checkpoint-sync-init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #608
Changes
pkgs/node/src/forkchoice.zigForkChoiceStatusenum (initing|ready)status: ForkChoiceStatusfield toForkChoiceready(existing behaviour unchanged)initing—latest_justifiedandlatest_finalizedstill hold the anchor checkpoint for internal forkchoice computation, but the node does not participate in validator duties until the first real justified update arrives viaonBlockonBlockUnlocked: whenfcStore.update()advanceslatest_justifiedpast the anchor slot, status transitions toreadyand an[info]log is emittedpub fn isReady()method for callerspkgs/node/src/chain.zig.fc_initingvariant toSyncStatusgetSyncStatus()returns.fc_initingfirst when!forkChoice.isReady()pkgs/node/src/validator_client.zigmaybeDoProposalandmayBeDoAttestationnow handle.fc_initing— log and returnnull(skip duty)pkgs/node/src/node.zig.fc_initingto the exhaustive switch in the peer-status handlerTest Results
zig build test— 120/132 passed (12 pre-existing failures: IoUring PermissionDenied in sandbox + tree_visualizer — identical tomainwithout changes)