Skip to content

build all zkvm binaries + cli at once#4

Merged
g11tech merged 2 commits intomainfrom
build-all-bins
Mar 8, 2025
Merged

build all zkvm binaries + cli at once#4
g11tech merged 2 commits intomainfrom
build-all-bins

Conversation

@gballet
Copy link
Copy Markdown
Contributor

@gballet gballet commented Mar 3, 2025

Changes the build system to build all supported platforms in one go when typing zig build. We will further extend it to also build the full client down the road. This is a prerequisite for #3

EDIT

This now builds every binary at once, using zig build. It's only building the tests for the state transition.

TODO

  • build tests for all packages
  • rename the pkgs/ subdirectory to src/, since all modules are no longer stored as independent packages
  • remove all other src/ subdirectories
  • rebase :(

@gballet gballet requested a review from g11tech March 3, 2025 20:57
@g11tech
Copy link
Copy Markdown
Member

g11tech commented Mar 4, 2025

i somehow feel the top level builds should be like triggering the all the package builds, and test trigger all package level tests

a monorepo kinda build system

@gballet
Copy link
Copy Markdown
Contributor Author

gballet commented Mar 4, 2025

i somehow feel the top level builds should be like triggering the all the package builds, and test trigger all package level tests

a monorepo kinda build system

yes, and I want to do that as well. I was just doing the first part, but I can expand.

@gballet gballet changed the title build all zkvm binaries at once build all zkvm binaries + cli at once Mar 6, 2025
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
@g11tech g11tech merged commit 1f39d9e into main Mar 8, 2025
4 checks passed
Copy link
Copy Markdown
Member

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech deleted the build-all-bins branch March 11, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants