Merged
Conversation
eb27f7c to
f20cdee
Compare
g11tech
commented
Sep 12, 2025
| pub const ValidatorIndex = u64; | ||
| pub const Bytes48 = [48]u8; | ||
|
|
||
| pub const SIGSIZE = 40; |
Member
Author
There was a problem hiding this comment.
@gballet weird error ssz comes over here when this is bumped to 4000 for devnet 0 spec (works fine for 400 as well)
could you take a look at what fix is needed at ssz lib
Member
Author
There was a problem hiding this comment.
@noopur23 can you create an issue for this : to update signature size to 4000 after ssz is fixed, so that we can close/merge this PR, also add it as a comment on top of SIGSIZE declaration
Contributor
There was a problem hiding this comment.
that's an easy fix, I'll push it wqhen I can catch a break
gballet
reviewed
Sep 13, 2025
gballet
reviewed
Sep 13, 2025
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
g11tech
commented
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@noopur23 can you get this PR & tests working