feat: change basic clock tick to interval from slot#135
Merged
Conversation
gballet
reviewed
Sep 4, 2025
gballet
reviewed
Sep 4, 2025
| self.tickSlot(slot); | ||
| pub fn registerValidatorIds(self: *Self, validator_ids: []usize) void { | ||
| // right now its simple assignment but eventually it should be a set | ||
| // tacking registrations and keeping it alive for 3*2=6 slots |
Contributor
There was a problem hiding this comment.
so some kind of expiring LRU ?
Member
Author
There was a problem hiding this comment.
yes thats how it handled in the beacon clients, every epoch validators register so that proposal stuff can be timely initiated at start of slot
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
gballet
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change node tick to intervals instead of slots in prep for devnet0 updates