Skip to content

Conversation

@wolf31o2
Copy link
Member

@wolf31o2 wolf31o2 commented Nov 29, 2025

Summary by cubic

Updated the publish workflow to build release binaries with Go 1.25.x. This keeps CI on the latest stable Go and ensures consistent, up-to-date builds across OS/arch.

Written for commit 9cd6a0c. Summary will update automatically on new commits.

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain version used in the build pipeline.

✏️ Tip: You can customize this high-level summary in your review settings.

@wolf31o2 wolf31o2 requested a review from a team as a code owner November 29, 2025 14:33
@coderabbitai
Copy link

coderabbitai bot commented Nov 29, 2025

📝 Walkthrough

Walkthrough

This pull request updates the Go toolchain version in the CI workflow configuration. The .github/workflows/publish.yml file is modified to upgrade Go from version 1.24.x to 1.25.x. The change is applied in two locations where actions/setup-go@v6 is configured. No other workflow behavior or steps are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple, homogeneous version update repeated consistently across two locations
  • Single file affected with minimal surface area
  • No logic changes or workflow structural modifications
  • Straightforward verification of version numbers

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the Go toolchain version from 1.24.x to 1.25.x in the publish workflow.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch build/go-1.25

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 085534c and 9cd6a0c.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
.github/workflows/publish.yml (1)

1-180: Note: AI summary mentions "both locations" but only one Go setup is visible.

The summary states changes are applied "in both locations where actions/setup-go@v6 is configured," but the provided file shows only one actions/setup-go@v6 at line 63. Verify whether there's a second location that should also be updated, or if the summary description is inaccurate.

Comment on lines 63 to +65
- uses: actions/setup-go@v6
with:
go-version: 1.24.x
go-version: 1.25.x
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# View the complete .github/workflows/publish.yml to check for all setup-go actions
if [ -f .github/workflows/publish.yml ]; then
  echo "=== Full publish.yml workflow ==="
  cat -n .github/workflows/publish.yml
  echo -e "\n=== Searching for all setup-go occurrences ==="
  rg -n "setup-go" .github/workflows/publish.yml -C 3
else
  echo "File not found at .github/workflows/publish.yml"
fi

Repository: blinklabs-io/tx-submit-api

Length of output: 7499


🌐 Web query:

Go 1.25.x release stable

💡 Result:

Yes — Go 1.25 is stable. go1.25.0 was released on August 12, 2025; the latest 1.25.x minor release is go1.25.2 (released October 7, 2025). [1][2]

Sources:
[1] Go release history (go1.25.0, go1.25.1, go1.25.2).
[2] Go 1.25 Release Notes.


🏁 Script executed:

#!/bin/bash
# Check go.mod and look for any version constraints or build considerations
if [ -f go.mod ]; then
  echo "=== go.mod content ==="
  head -20 go.mod
  echo -e "\n=== Checking for any Go version constraints ==="
  rg -n "go [0-9]" go.mod
fi

Repository: blinklabs-io/tx-submit-api

Length of output: 700


Update Go to 1.25.x for binary builds, but go.mod should also be updated for consistency.

Go 1.25.x is stable (latest is 1.25.2 as of October 2025). However, the workflow change at line 65 should be paired with updating go.mod from go 1.24.0 to go 1.25.0 to keep the project's Go version declaration consistent. Currently, the workflow will build with 1.25.x while go.mod still declares 1.24.0, which may cause confusion or compatibility issues with tools and IDEs.

Additionally, the AI summary incorrectly states changes are "in both locations where actions/setup-go@v6 is configured"—there is only one setup-go action in this workflow (lines 63–65 in the build-binaries job).

🤖 Prompt for AI Agents
In .github/workflows/publish.yml around lines 63–65, the workflow uses
actions/setup-go@v6 with go-version: 1.25.x while go.mod still declares go
1.24.0; update the module declaration in go.mod from "go 1.24.0" to "go 1.25.0"
to match the CI, then run go mod tidy (or go mod download) locally to ensure
module files are consistent; also correct any PR/summary text that incorrectly
claims multiple setup-go locations — there is only one setup-go usage in this
workflow.

@wolf31o2 wolf31o2 merged commit 48a1ea0 into main Nov 29, 2025
11 checks passed
@wolf31o2 wolf31o2 deleted the build/go-1.25 branch November 29, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants