Skip to content

Conversation

jkawan
Copy link
Contributor

@jkawan jkawan commented Jul 26, 2025

  1. Added tests for utxorpc block functions for all the eras except Babbage( Babbage era has an issue while decoding,issue Babbage blocks fail decoding to CBOR #1113 has been created)

Closes #1027

@jkawan jkawan requested a review from a team as a code owner July 26, 2025 01:51
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested

if o.OutputDatumHash != nil {
datumHash = o.OutputDatumHash.Bytes()
} else {
fmt.Printf("No datum hash present")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed the comment, please review

@wolf31o2 wolf31o2 merged commit 1aace8d into main Jul 28, 2025
8 checks passed
@wolf31o2 wolf31o2 deleted the test_for_utxorpc branch July 28, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tests for UTxO RPC block functions
2 participants