Skip to content

fix(chainsync): Updated tests to use renamed and fixed-size Credentia Struct #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix(chainsync): Updated tests to use renamed and fixed-size Credentia Struct #395

merged 1 commit into from
Apr 7, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Updated test cases to use the renamed and fixed-size common.Credential struct instead of the old common.StakeCredential struct.
  2. Aligned stake address generation in tests with production logic by using Credential.Hash() and bech32 encoding to ensure accurate filter matching.
  3. Tested the changes and now all the test cases are working.

Closes #393

@arepala-uml arepala-uml marked this pull request as ready for review April 5, 2025 23:15
@arepala-uml arepala-uml requested a review from a team as a code owner April 5, 2025 23:15
@arepala-uml arepala-uml requested review from agaffney and wolf31o2 April 5, 2025 23:15
@wolf31o2 wolf31o2 merged commit 918b5f1 into main Apr 7, 2025
8 checks passed
@wolf31o2 wolf31o2 deleted the fix_credential branch April 7, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney Awaiting requested review from agaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests broken after gouroboros upgrade
2 participants
@arepala-uml @wolf31o2