add keep_matlab_shapes to oct2py #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tract datastructures with all matlab dimensions. This makes it easier to work with the data when sometimes there are singletons and sometimes not in the extracted data.
blink1073
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Thanks @tylerbjackson! Can you please add a test that uses the new option?
|
I have added some tests ensuring the new functionality works and doesn't interfere with previous behaviours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so there is an option to reliably extract datastructures with all matlab dimensions. This makes it easier to work with the data when sometimes there are singletons and sometimes not in the extracted data.
We were running into an issue where the shape of the structures we were pulling out would sometimes be like [n, 1, m] and sometimes [n, 3, m] and without this the singleton dimensions was being squeezed out often. Adding this option allows us to have more consistent return shapes and has proved helpful.