MB-71375: Bolt Wrappers for File Callbacks#2309
Merged
abhinavdangeti merged 3 commits intomasterfrom Apr 15, 2026
Merged
Conversation
Member
Likith101
commented
Apr 10, 2026
Likith101
commented
- Wrap bolt.DB, bolt.TX and bolt.Bucket with impls
- Override all bucket, transaction and key functions currently in use
- Use a map to track keys and bucket names that require file callback handling
- Process values internally before returning data outside the wrappers
- Wrap bolt.DB, bolt.TX and bolt.Bucket with impls - Override all bucket, transaction and key functions currently in use - Use a map to track keys and bucket names that require file callback handling - Process values internally before returning data outside the wrappers
Likith101
requested review from
CascadingRadium,
Thejas-bhat,
abhinavdangeti,
capemox and
maneuvertomars
|
coverage: 51.536% (-0.1%) from 51.682% — bolt into master |
Member
abhinavdangeti
left a comment
abhinavdangeti
left a comment
There was a problem hiding this comment.
Looks so much better now @Likith101 👍🏼 .
One comment - let's keep the redirect API names the same, change the member attributes to avoid that collision.
abhinavdangeti
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.