Skip to content

Conversation

@arulrajnet
Copy link
Author

@abhinavdangeti could you review this? Is there any other process I have missed in this PR?

@abhinavdangeti
Copy link
Member

@arulrajnet Thanks for the contribution.
Here's instructions on how to make your first contribution to the library - https://github.com/blevesearch/bleve/blob/master/CONTRIBUTING.md

@arulrajnet
Copy link
Author

@abhinavdangeti Already submitted CLA

image

Ran go fmt and go vet before given the PR.

@arulrajnet
Copy link
Author

@abhinavdangeti Any other process I have to follow to merge this PR.

Copy link

@sreekanth-cb sreekanth-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @arulrajnet,
I see that you have added stop words for Tamil, but bleve doesn't have a Tamil analyzer yet?
So are you planning to add support/port Tamil analyzer as well Or am I missing the context here?

@arulrajnet
Copy link
Author

Yes @sreekanth-cb . I want to add stemmer for Tamil language. Adding stop words is the first step for that. Since most of the lang in bleve at least has stop words.

@sreekanth-cb
Copy link

sreekanth-cb commented Jan 31, 2022

@arulrajnet, let's add some unit tests to this PR then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants