fix: replace deprecated rmdirSync with rmSync#171
Open
adam2am wants to merge 1 commit intoblackboardsh:mainfrom
Open
fix: replace deprecated rmdirSync with rmSync#171adam2am wants to merge 1 commit intoblackboardsh:mainfrom
adam2am wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
Replaces all occurrences of the deprecated rmdirSync API with the modern rmSync equivalent. This fixes TypeScript errors when using Bun's type checking with svelte-check. Changes: - package/src/bun/core/Updater.ts: 4 replacements (import + 3 usages) - package/src/cli/index.ts: 5 replacements (import + 4 usages) The rmdirSync API was deprecated in Node.js 14 in favor of rmSync. Tested with svelte-check and confirmed 0 errors after applying this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋
While building sveltekit+electrobun app I got hit by typescript from
svelte-checkwith:Happens in 3 spots. So I decided to ship pr to update deprecated
rmdirSyncRefs: DEP0147 | rmSync docs
Fix
Replace
rmdirSyncwithrmSync- same signature, modern API.Files:
package/src/bun/core/Updater.ts(4 changes)package/src/cli/index.ts(5 changes)Your code already guards with
statSyncchecks, so noforce: trueneeded. Just a function name swap.Tested in my SvelteKit project, went from 3 errors to 0.