ci: add support for Node 16

.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       # Rebase must happen before installing dependencies.
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
@@ -31,7 +31,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       - name: npm install
         if: steps.cache.outputs.cache-hit != 'true'
         run: npm ci
@@ -73,7 +73,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       # Running ngcc after each agent is created to address the "ngcc is already running error".
       # Since we're running multiple builds in parallel, we need to pre-process our node_modules before starting the builds.
       - name: Run NGCC
@@ -92,7 +92,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       # Rebase must happen before installing dependencies.
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
@@ -102,7 +102,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       - name: Check library dependencies
         run: npx skyux-dev check-lib-dependencies
       - name: Check library missing peers
@@ -126,7 +126,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       # Rebase must happen before installing dependencies.
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
@@ -136,7 +136,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       - name: Run NGCC
         run: npx ngcc
       - name: Build
@@ -154,15 +154,15 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       # Rebase must happen before installing dependencies.
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
       - name: Retrieve node_modules cache
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       - name: Build packages dist
         run: npx skyux-dev create-packages-dist
 
@@ -177,7 +177,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       # Rebase must happen before installing dependencies.
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
@@ -187,7 +187,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       - name: Run NGCC
         run: npx ngcc
       - name: Code coverage
@@ -204,11 +204,11 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       - name: Retrieve node_modules cache
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       - name: Stop Nx Cloud agents
         run: npx nx-cloud stop-all-agents

.github/workflows/e2e.yml

@@ -29,7 +29,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
           cache: 'npm'
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
@@ -41,7 +41,7 @@ jobs:
             node_modules
             !node_modules\.cache\nx
             C:\Users\runneradmin\AppData\Local\Cypress\Cache
-          key: cache-pr-preview-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
+          key: cache-pr-preview_node16.18_-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
       - name: npm install
         if: steps.cache.outputs.cache-hit != 'true'
         run: npm ci
@@ -91,7 +91,7 @@ jobs:
         if: ${{ matrix.project != 'skip' }}
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
         if: ${{ matrix.project != 'skip' }}
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
@@ -103,7 +103,7 @@ jobs:
             node_modules
             !node_modules\.cache\nx
             C:\Users\runneradmin\AppData\Local\Cypress\Cache
-          key: cache-pr-preview-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
+          key: cache-pr-preview_node16.18_-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
         if: ${{ matrix.project != 'skip' }}
       - name: Build ${{ matrix.project }}
         # https://github.com/actions/github-script
@@ -146,7 +146,7 @@ jobs:
         if: ${{ github.event_name == 'pull_request' }}
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
         if: ${{ github.event_name == 'pull_request' }}
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
@@ -158,7 +158,7 @@ jobs:
             node_modules
             !node_modules\.cache\nx
             C:\Users\runneradmin\AppData\Local\Cypress\Cache
-          key: cache-pr-preview-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
+          key: cache-pr-preview_node16.18_-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
         if: ${{ github.event_name == 'pull_request' }}
       - name: Build ${{ matrix.app }}
         run: |
@@ -192,7 +192,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
       - name: Retrieve dependencies cache
@@ -202,7 +202,7 @@ jobs:
             node_modules
             !node_modules\.cache\nx
             C:\Users\runneradmin\AppData\Local\Cypress\Cache
-          key: cache-pr-preview-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
+          key: cache-pr-preview_node16.18_-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
       - name: Download artifacts
         uses: actions/download-artifact@v3
         with:
@@ -263,7 +263,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '16.18.x'
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
       - name: Retrieve dependencies cache
@@ -273,7 +273,7 @@ jobs:
             node_modules
             !node_modules\.cache\nx
             C:\Users\runneradmin\AppData\Local\Cypress\Cache
-          key: cache-pr-preview-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
+          key: cache-pr-preview_node16.18_-${{ runner.os }}-${{ hashFiles('package-lock.json') }}
       - name: Percy ${{ matrix.project }}
         # Timing setting recommended by https://docs.percy.io/docs/cypress#missing-assets
         run: npx percy exec -t 350 -- nx e2e ${{ matrix.project }}-e2e --skip-nx-cache

.github/workflows/release-please.yml

@@ -27,7 +27,7 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           cache: npm
-          node-version: '14'
+          node-version: '16.18.x'
       # Workaround to avoid "Post Run actions/setup-node" failures.
       # See: https://github.com/actions/setup-node/issues/317
       - name: Ensure cache directory exists
@@ -40,7 +40,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: node_modules
-          key: cache-node-modules-${{ hashFiles('package-lock.json') }}
+          key: cache-node-modules_node16.18_${{ hashFiles('package-lock.json') }}
       - name: npm install
         if: ${{ steps.release.outputs.release_created && steps.cache.outputs.cache-hit != 'true' }}
         run: npm ci

.npmrc

@@ -0,0 +1 @@
+engine-strict=true

.nvmrc

@@ -1 +1 @@
-14
+16.18

libs/components/ag-grid/src/lib/modules/ag-grid/cell-editors/cell-editor-lookup/cell-editor-lookup.component.spec.ts

@@ -6,7 +6,6 @@ import { SkyInputBoxModule } from '@skyux/forms';
 import { SkyLookupModule, SkyLookupSelectModeType } from '@skyux/lookup';
 
 import { Column, KeyCode } from 'ag-grid-community';
-import { EventCallback } from 'typedoc/dist/lib/utils/events';
 
 import { SkyCellEditorLookupParams } from '../../types/cell-editor-lookup-params';
 
@@ -22,7 +21,7 @@ describe('SkyAgGridCellEditorLookupComponent', () => {
   ];
   let fixture: ComponentFixture<SkyAgGridCellEditorLookupComponent>;
   let nativeElement: HTMLElement;
-  let callback: EventCallback | undefined;
+  let callback: (args: Record<string, unknown>) => void | undefined;
   const selection = [data[0]];
   let cellEditorParams: SkyCellEditorLookupParams;
 
@@ -48,7 +47,10 @@ describe('SkyAgGridCellEditorLookupComponent', () => {
       },
       column: {
         getActualWidth: () => 123,
-        addEventListener: (event: string, listener: EventCallback) => {
+        addEventListener: (
+          event: string,
+          listener: (args: Record<string, unknown>) => void
+        ) => {
           callback = listener;
           [event].pop();
         },