-
Notifications
You must be signed in to change notification settings - Fork 34
feat(components/tabs): wizard keyboard nav and roles #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
20de903
set role to link when in wizard mode
Blackbaud-ErikaMcVey 62b89d4
make modal region unfocusable
Blackbaud-ErikaMcVey 523cf85
tab buttons keyboard nav
Blackbaud-ErikaMcVey 2d4ad48
better name for focus first/last tab functions
Blackbaud-ErikaMcVey 4fc23b1
use defaults for roles
Blackbaud-ErikaMcVey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 5 additions & 1 deletion
6
libs/components/tabs/src/lib/modules/tabs/fixtures/tabset.component.fixture.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
libs/components/tabs/src/lib/modules/tabs/tab-button-adapter.service.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { ElementRef, Injectable } from '@angular/core'; | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| @Injectable() | ||
| export class SkyTabButtonAdapterService { | ||
| public focusButtonLink(buttonEl: ElementRef): void { | ||
| buttonEl.nativeElement.querySelector('a').focus(); | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
libs/components/tabs/src/lib/modules/tabs/tab-button-view-model.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { SkyTabIndex } from './tab-index'; | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| export type TabButtonViewModel = { | ||
| active: boolean; | ||
| ariaControls: string; | ||
| buttonHref: string; | ||
| buttonId: string; | ||
| buttonText: string; | ||
| buttonTextCount: string; | ||
| closeable: boolean; | ||
| disabled: boolean; | ||
| tabIndex: SkyTabIndex; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.