Skip to content

fix(components/ag-grid): apply minimum height override to column container (#4333)#4335

Merged
johnhwhite merged 1 commit intomainfrom
cherry-pick_95fc062d0_1774370661690
Mar 24, 2026
Merged

fix(components/ag-grid): apply minimum height override to column container (#4333)#4335
johnhwhite merged 1 commit intomainfrom
cherry-pick_95fc062d0_1774370661690

Conversation

@johnhwhite
Copy link
Copy Markdown
Member

@johnhwhite johnhwhite commented Mar 24, 2026

AB#3926782 🍒 #4333

Summary by CodeRabbit

  • Style
    • Refined AG Grid component height styling to improve layout consistency across grid sub-containers.

@johnhwhite johnhwhite added the risk level (author): 1 No additional bugs expected from this change label Mar 24, 2026
@johnhwhite johnhwhite temporarily deployed to e2e-team-members March 24, 2026 17:52 — with GitHub Actions Inactive
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 684ea3a3-88bc-4e09-91a3-9245c47ee20e

📥 Commits

Reviewing files that changed from the base of the PR and between 3524bf7 and 138ad30.

📒 Files selected for processing (1)
  • libs/components/ag-grid/src/lib/styles/_base.scss

📝 Walkthrough

Walkthrough

A CSS selector in the AG Grid styles file has been modified to apply the auto-height min-height rule to both .ag-center-cols-container and .ag-center-cols-viewport, expanding the scope of the styling rule beyond its previous narrower target.

Changes

Cohort / File(s) Summary
AG Grid Styling
libs/components/ag-grid/src/lib/styles/_base.scss
Modified the .ag-layout-auto-height selector to apply min-height to both .ag-center-cols-container and .ag-center-cols-viewport instead of only the viewport, broadening the min-height enforcement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • Blackbaud-TrevorBurch

Poem

🐰 Whiskers twitch with CSS delight,
A selector grows, the layout takes flight,
Min-height spreads wide, containers align,
AG Grid now glows with measured design!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: applying a minimum height override to the AG Grid column container, which matches the core modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cherry-pick_95fc062d0_1774370661690

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 24, 2026

View your CI Pipeline Execution ↗ for commit 138ad30

Command Status Duration Result
nx build code-examples-playground --baseHref=ht... ✅ Succeeded 1m 58s View ↗
nx build playground --baseHref=https://blackbau... ✅ Succeeded 1m 43s View ↗
nx build integration --baseHref=https://blackba... ✅ Succeeded 29s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-24 17:58:22 UTC

@blackbaud-sky-build-user
Copy link
Copy Markdown
Collaborator

@johnhwhite johnhwhite enabled auto-merge (squash) March 24, 2026 19:04
@johnhwhite johnhwhite merged commit 123c4b0 into main Mar 24, 2026
40 of 41 checks passed
@johnhwhite johnhwhite deleted the cherry-pick_95fc062d0_1774370661690 branch March 24, 2026 19:04
Blackbaud-ErikaMcVey pushed a commit that referenced this pull request Mar 25, 2026
##
[14.0.0-alpha.14](14.0.0-alpha.13...14.0.0-alpha.14)
(2026-03-25)


### Features

* update design tokens
([#4340](#4340))
([a8eb7cf](a8eb7cf))


### Bug Fixes

* **components/ag-grid:** apply minimum height override to column
container ([#4333](#4333))
([#4335](#4335))
([123c4b0](123c4b0)),
closes
[AB#3926782](https://dev.azure.com/blackbaud/Products/_workitems/edit/3926782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk level (author): 1 No additional bugs expected from this change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants