fix(components/data-manager): address data mutation during view updates (#4309)

[blackbaud-sky-build-user]

🍒 Cherry picked from #4309 fix(components/data-manager): address data mutation during view updates

AB#3705639

Summary by CodeRabbit

• Refactor

  • Improved state management consistency through immutable state updates in the data manager, enhancing data integrity and reliability.

• Tests

  • Expanded test coverage for edge cases in state handling and column configuration with improved test infrastructure.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request refactors the data-manager library and ag-grid adapter to use immutable-style state updates instead of in-place mutations. A new safeStructuredClone utility function is introduced to safely clone state properties, and multiple modules are updated to create new state instances when applying changes. Comprehensive tests validate the immutable state handling and cloning semantics.

Changes

Cohort / File(s)	Summary
Ag-grid adapter directive ag-grid-data-manager-adapter.directive.ts	Replaced in-place mutations of SkyDataManagerState with immutable updates by creating new state instances for selectedIds, activeSortOption, and view-level state (displayedColumnIds, columnWidths) in event handlers.
Data-manager service core data-manager.service.ts	Introduces updatedViewState copies to replace direct mutations; creates new state instances when updating views via addOrUpdateView instead of mutating existing view state objects.
Data-manager state models data-manager-state.ts, data-view-state.ts	Integrated safeStructuredClone utility for cloning public state properties; addOrUpdateView creates shallow copies of views array and returns new SkyDataManagerState instances; getViewStateOptions returns defensive copies of arrays and columnWidths objects.
Safe structured clone utility safe-structured-clone.ts, safe-structured-clone.spec.ts	New internal utility function that safely clones values using structuredClone with graceful fallback to original value on failure or for non-cloneable types; includes comprehensive test coverage for edge cases.
Data-manager service tests data-manager.service.spec.ts	Centralized subscription lifecycle management using unified Subscription tracking; added new "distinctUntilChanged with shared mutable state" test block validating immutable state handling, mutation behavior, and cloning semantics.
Data-view state tests data-view-state.spec.ts	New test file validating columnWidths normalization in both SkyDataViewState constructor and getViewStateOptions to ensure xs and sm properties are always defined objects.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• fix(components/data-manager): address data mutation during view updates #4309: Implements the same immutable state update pattern by replacing in-place mutations of SkyDataManagerState and SkyDataViewState with new instance creation and defensive cloning of state fields.

Suggested reviewers

• Blackbaud-SteveBrush
• johnhwhite

Poem

🐰 With whiskers twitched and hop of glee,
No more mutations here shall be!
New states rise fresh, old refs untouched,
Immutable patterns we've clutched.
A safer grove for data's song! 🌿✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the main change: addressing data mutation issues during view updates in the data-manager component, which aligns with the core refactoring across multiple files to replace in-place mutations with immutable-style state updates.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cherry-pick_328efabc7ef53c81f59db64cc8619faa3b4c033f_1773766740603

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 4ee10d4

Command	Status	Duration	Result
nx build code-examples-playground --baseHref=ht...	✅ Succeeded	3m 57s	View ↗
nx build playground --baseHref=https://blackbau...	✅ Succeeded	1m 47s	View ↗
nx build integration --baseHref=https://blackba...	✅ Succeeded	34s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-03-17 17:07:51 UTC

[blackbaud-sky-build-user]

Storybook preview

Component Storybooks:

• ag-grid-storybook
• data-manager-storybook

Apps:

• code-examples-playground
• integration
• playground