Skip to content

fix(components/lookup): lookup and selections modals use correct footer button spacing in modern theme (#4229)#4230

Merged
Blackbaud-TrevorBurch merged 1 commit intomainfrom
cherry-pick_6453f81286687035440e68106dfc9f2762c2dc7e_1771874054996
Feb 23, 2026
Merged

fix(components/lookup): lookup and selections modals use correct footer button spacing in modern theme (#4229)#4230
Blackbaud-TrevorBurch merged 1 commit intomainfrom
cherry-pick_6453f81286687035440e68106dfc9f2762c2dc7e_1771874054996

Conversation

@blackbaud-sky-build-user
Copy link
Copy Markdown
Collaborator

@blackbaud-sky-build-user blackbaud-sky-build-user commented Feb 23, 2026

🍒 Cherry picked from #4229 fix(components/lookup): lookup and selections modals use correct footer button spacing in modern theme

AB#3704526

Summary by CodeRabbit

  • Style
    • Updated button spacing in lookup and selection modal footers to be theme-aware, replacing fixed margins with conditional spacing that responds to the active theme selection.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 695f7d6 and 41ece68.

📒 Files selected for processing (2)
  • libs/components/lookup/src/lib/modules/lookup/lookup-show-more-modal.component.html
  • libs/components/lookup/src/lib/modules/selection-modal/selection-modal.component.html

📝 Walkthrough

Walkthrough

Two modal component templates are updated to apply margin styling conditionally based on the active theme rather than statically. The sky-margin-inline-compact class now binds to a theme condition, affecting only presentation logic without altering component behavior or event handling.

Changes

Cohort / File(s) Summary
Modal Theme-Based Styling
libs/components/lookup/src/lib/modules/lookup/lookup-show-more-modal.component.html, libs/components/lookup/src/lib/modules/selection-modal/selection-modal.component.html
Primary button margins changed from static class to dynamic theme-based binding. The sky-margin-inline-compact class now conditionally applies when the default theme is active, removing fixed styling in favor of theme-driven presentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • Blackbaud-ErikaMcVey
  • Blackbaud-SteveBrush

Poem

🐰 The modals shine with theme-aware grace,
No static margins cluttering the place,
Sky margins dance with conditions so keen,
Default theme's the prettiest seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing footer button spacing in lookup and selection modals for the modern theme, which aligns with the conditional theme-based styling changes in both components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cherry-pick_6453f81286687035440e68106dfc9f2762c2dc7e_1771874054996

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Feb 23, 2026

View your CI Pipeline Execution ↗ for commit 41ece68

Command Status Duration Result
nx build playground --baseHref=https://blackbau... ✅ Succeeded 2m 6s View ↗
nx build code-examples-playground --baseHref=ht... ✅ Succeeded 2m 11s View ↗
nx build integration --baseHref=https://blackba... ✅ Succeeded 51s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-23 19:24:59 UTC

@blackbaud-sky-build-user
Copy link
Copy Markdown
Collaborator Author

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch enabled auto-merge (squash) February 23, 2026 20:05
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 401f83e into main Feb 23, 2026
71 of 72 checks passed
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the cherry-pick_6453f81286687035440e68106dfc9f2762c2dc7e_1771874054996 branch February 23, 2026 20:07
johnhwhite added a commit that referenced this pull request Feb 24, 2026
* origin/main:
  feat(components/grids)!: replace `dragula` with `@angular/cdk/drag-drop` (#4224)
  fix(components/lookup): lookup and selections modals use correct footer button spacing in modern theme (#4229) (#4230)
Blackbaud-SteveBrush pushed a commit that referenced this pull request Feb 24, 2026
##
[14.0.0-alpha.2](14.0.0-alpha.1...14.0.0-alpha.2)
(2026-02-24)


### ⚠ BREAKING CHANGES

* **components/lists:** replace `dragula` with `@angular/cdk/drag-drop`
(#4228)
* **components/tiles:** replace `dragula` with `@angular/cdk/drag-drop`
(#4225)
* delete source for `@skyux-sdk/prettier-schematics` (#4222)
* **components/grids:** replace `dragula` with `@angular/cdk/drag-drop`
(#4224)

### Features

* **components/grids:** replace `dragula` with `@angular/cdk/drag-drop`
([#4224](#4224))
([6f96cb0](6f96cb0))
* **components/lists:** replace `dragula` with `@angular/cdk/drag-drop`
([#4228](#4228))
([fd18fcb](fd18fcb)),
closes
[AB#3390474](https://dev.azure.com/blackbaud/Products/_workitems/edit/3390474)
* **components/packages:** remove `dragula`, `ng2-dragula`, and
`dom-autoscroller` if not used
([#4233](#4233))
([5b41e02](5b41e02)),
closes
[AB#3390474](https://dev.azure.com/blackbaud/Products/_workitems/edit/3390474)
* **components/text-editor:** update dompurify
([#4190](#4190))
([8868e16](8868e16)),
closes
[AB#3642976](https://dev.azure.com/blackbaud/Products/_workitems/edit/3642976)
[AB#3691546](https://dev.azure.com/blackbaud/Products/_workitems/edit/3691546)
* **components/tiles:** replace `dragula` with `@angular/cdk/drag-drop`
([#4225](#4225))
([d8a7eb1](d8a7eb1)),
closes
[AB#3390474](https://dev.azure.com/blackbaud/Products/_workitems/edit/3390474)
* delete source for `@skyux-sdk/prettier-schematics`
([#4222](#4222))
([6579df0](6579df0)),
closes
[AB#3674220](https://dev.azure.com/blackbaud/Products/_workitems/edit/3674220)
* **sdk/testing:** remove support for older versions of axe-core
([#4215](#4215))
([410a073](410a073))
* update ng2-dragula
([#4192](#4192))
([2f5b748](2f5b748)),
closes
[AB#3642976](https://dev.azure.com/blackbaud/Products/_workitems/edit/3642976)
[AB#3691547](https://dev.azure.com/blackbaud/Products/_workitems/edit/3691547)


### Bug Fixes

* **components/action-bars:** default theme summary action bar secondary
action button dropdown uses correct button class
([#4188](#4188))
([#4193](#4193))
([bc8ede1](bc8ede1)),
closes
[AB#3696493](https://dev.azure.com/blackbaud/Products/_workitems/edit/3696493)
* **components/data-manager:** set docked data manager to be `inset`
([#4180](#4180))
([#4186](#4186))
([0281ca1](0281ca1)),
closes
[AB#3689062](https://dev.azure.com/blackbaud/Products/_workitems/edit/3689062)
* **components/filter-bar:** recast filter value type as interface for
documentation parsing
([#4202](#4202))
([#4203](#4203))
([2344664](2344664))
* **components/forms:** select inputs have proper text overflow and
right padding ([#4168](#4168))
([#4194](#4194))
([7e04020](7e04020)),
closes
[AB#3673505](https://dev.azure.com/blackbaud/Products/_workitems/edit/3673505)
* **components/list-builder:** stop overriding dropdown button padding
([#4181](#4181))
([#4217](#4217))
([695f7d6](695f7d6))
* **components/lookup:** lookup and selections modals use correct footer
button spacing in modern theme
([#4229](#4229))
([#4230](#4230))
([401f83e](401f83e)),
closes
[AB#3704526](https://dev.azure.com/blackbaud/Products/_workitems/edit/3704526)
* run check-workspace on release pr
([#4210](#4210))
([#4213](#4213))
([823d2c8](823d2c8)),
closes
[AB#3647615](https://dev.azure.com/blackbaud/Products/_workitems/edit/3647615)
* use accessible text colors via design tokens update
([#4234](#4234))
([#4236](#4236))
([7732ede](7732ede))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk level (author): 1 No additional bugs expected from this change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants