Skip to content

feat(components/ag-grid): auto-populate column configuration for data manager#4153

Merged
johnhwhite merged 1 commit intomainfrom
configure-data-manager-columns-for-ag-grid
Jan 14, 2026
Merged

feat(components/ag-grid): auto-populate column configuration for data manager#4153
johnhwhite merged 1 commit intomainfrom
configure-data-manager-columns-for-ag-grid

Conversation

@johnhwhite
Copy link
Copy Markdown
Member

@johnhwhite johnhwhite commented Jan 14, 2026 •
edited by azure-boards bot
Loading

@johnhwhite johnhwhite added the risk level (author): 1 No additional bugs expected from this change label Jan 14, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Jan 14, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0d2d244

Command Status Duration Result
nx build code-examples-playground --baseHref=ht... ✅ Succeeded 3m 50s View ↗
nx build playground --baseHref=https://blackbau... ✅ Succeeded 1m 35s View ↗
nx build integration --baseHref=https://blackba... ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-14 19:41:50 UTC

@johnhwhite johnhwhite requested a review from Copilot January 14, 2026 01:42
@blackbaud-sky-build-user
Copy link
Copy Markdown
Collaborator

blackbaud-sky-build-user commented Jan 14, 2026

Storybook preview

Component Storybooks:

Apps:

Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@johnhwhite johnhwhite requested a review from Copilot January 14, 2026 02:51
Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Jan 14, 2026
@johnhwhite johnhwhite enabled auto-merge (squash) January 14, 2026 17:40
@johnhwhite johnhwhite requested a review from Copilot January 14, 2026 18:42
Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 14, 2026

@johnhwhite I've opened a new pull request, #4154, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Jan 14, 2026
Merged
johnhwhite added a commit that referenced this pull request Jan 14, 2026
@johnhwhite
refactor(components/ag-grid): remove distinctUntilChanged and add loc…
5e01a78 
…kVisible test (#4154)

Addresses two code review comments from #4153:

## Changes

- **Removed `distinctUntilChanged()` operator** from breakpoint signal -
provides negligible performance benefit since `toColumnWidthName`
already deduplicates by collapsing 'md'/'lg' → 'sm'

- **Added test assertion for `lockVisible` behavior** - verifies
`nameColumn.alwaysDisplayed` is true when column has `lockVisible:
true`, validating the directive logic at line 532

```typescript
// Before
readonly #breakpoint = toSignal(
  inject(SkyMediaQueryService).breakpointChange.pipe(
    map(toColumnWidthName),
    distinctUntilChanged(),  // Removed
  ),
);

// After  
readonly #breakpoint = toSignal(
  inject(SkyMediaQueryService).breakpointChange.pipe(
    map(toColumnWidthName),
  ),
);
```

<!-- START COPILOT CODING AGENT TIPS -->
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: johnhwhite <750350+johnhwhite@users.noreply.github.com>
@johnhwhite johnhwhite disabled auto-merge January 14, 2026 19:03
@johnhwhite johnhwhite force-pushed the configure-data-manager-columns-for-ag-grid branch from 0ac10e8 to 0d2d244 Compare January 14, 2026 19:35
@johnhwhite johnhwhite merged commit e0a82b1 into main Jan 14, 2026
24 checks passed
@johnhwhite johnhwhite deleted the configure-data-manager-columns-for-ag-grid branch January 14, 2026 21:42
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jan 14, 2026
Merged
Blackbaud-SandhyaRajasabeson pushed a commit that referenced this pull request Jan 15, 2026
@blackbaud-sky-build-user
chore: release 13.12.0 (#4145)
6df918c 
#
[13.12.0](13.11.5...13.12.0)
(2026-01-15)


### Features

* **components/ag-grid:** auto-populate column configuration for data
manager ([#4153](#4153))
([e0a82b1](e0a82b1)),
closes [AB#3642107](https://github.com/AB/issues/3642107)
* **components/ag-grid:** provide test harness for AG Grid
([#4150](#4150))
([2a119cb](2a119cb)),
closes [AB#3672986](https://github.com/AB/issues/3672986)
[#4063](#4063)
* **components/filter-bar:** add generics for filter types
([#4144](#4144))
([3108198](3108198)),
closes [AB#3605105](https://github.com/AB/issues/3605105)
* **components/lookup:** support searching when minimum characters is
set to 0 ([#4133](#4133))
([806e17e](806e17e)),
closes [AB#3605881](https://github.com/AB/issues/3605881)
* **components/theme:** visual test data viz colors and add to public
API ([#4146](#4146))
([112f2cd](112f2cd))
johnhwhite added a commit that referenced this pull request Jan 16, 2026
@johnhwhite
Merge remote-tracking branch 'origin/main' into data-grid
5e0480e 
* origin/main:
  chore: release 13.12.0 (#4145)
  feat(components/ag-grid): auto-populate column configuration for data manager (#4153)
  feat(components/theme): visual test data viz colors and add to public API (#4146)
  feat(components/lookup): support searching when minimum characters is set to 0 (#4133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Blackbaud-SteveBrush Blackbaud-SteveBrush Blackbaud-SteveBrush approved these changes

Assignees

@Blackbaud-SteveBrush Blackbaud-SteveBrush

Labels

risk level (author): 1 No additional bugs expected from this change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@johnhwhite @blackbaud-sky-build-user @Blackbaud-SteveBrush