Merge branch 'main' into confirm-test-harness

Author: Blackbaud-SteveBrush

.github/workflows/e2e-cleanup.yml

@@ -0,0 +1,48 @@
+# Nightly cleanup to remove old PRs from skyux-pr-preview. Runs at 3:00 AM UTC.
+
+name: E2E Cleanup
+
+on:
+  schedule:
+    - cron: '0 3 * * *'
+
+jobs:
+  cleanup:
+    name: Cleanup
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout blackbaud/skyux-pr-preview
+        uses: actions/checkout@v3
+        with:
+          repository: blackbaud/skyux-pr-preview
+          ref: 'main'
+          fetch-depth: 1
+          token: ${{secrets.GH_PERSONAL_ACCESS_TOKEN}}
+      - name: Delete old PR previews
+        run: |
+          # List open PR numbers and save to a temporary file.
+          gh pr list -R blackbaud/skyux -s open --json number --jq '.[] | .number' > ${{ runner.temp }}/open-prs.txt
+
+          # List the checkout files, filter to just number directories, filter out open PRs.
+          ls | grep -E '^[0-9]+$' | grep -v -f ${{ runner.temp }}/open-prs.txt > ${{ runner.temp }}/delete-prs.txt
+
+          # Delete the directories.
+          for pr in $(cat ${{ runner.temp }}/delete-prs.txt)
+          do
+            if [[ -d $pr ]]
+            then
+              echo "Deleting $pr"
+              git rm -qrf $pr
+            fi
+          done
+
+          # If there are any changes, configure the user, commit the deletions, and push to skyux-pr-preview repo.
+          if [[ -n "$(git status --porcelain)" ]]
+          then
+            git config user.name 'Blackbaud Sky Build User'
+            git config user.email 'sky-build-user@blackbaud.com'
+            git commit -m "Delete old PR previews $(date +'%Y-%m-%d')"
+            git push
+          fi
+        env:
+          GITHUB_TOKEN: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}

.github/workflows/release-please.yml

@@ -11,6 +11,7 @@ jobs:
       - uses: google-github-actions/release-please-action@v3
         id: release
         with:
+          changelog-types: '[{"type":"feat","section":"Features","hidden":false},{"type":"fix","section":"Bug Fixes","hidden":false},{"type":"deprecation","section":"Deprecations","hidden":false}]'
           release-type: 'node'
           default-branch: '${{ github.ref_name }}'
           package-name: 'skyux'

CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [6.19.0](https://github.com/blackbaud/skyux/compare/6.18.0...6.19.0) (2022-09-14)
+
+
+### Features
+
+* **components/indicators:** add key info component harness ([#498](https://github.com/blackbaud/skyux/issues/498)) ([4ba11a0](https://github.com/blackbaud/skyux/commit/4ba11a050ad09e762f718cc613ffb55bfdb686ff))
+* **components/indicators:** update alert test harness with accessibility functions ([#500](https://github.com/blackbaud/skyux/issues/500)) ([ee7c8bf](https://github.com/blackbaud/skyux/commit/ee7c8bf424b3542674cfbeb2a145a4e88bd86cba))
+
+
+### Deprecations
+
+* **components/modals:** deprecate confirm autofocus ([#507](https://github.com/blackbaud/skyux/issues/507)) ([67a0fa9](https://github.com/blackbaud/skyux/commit/67a0fa92f6a185e2976fd63330fc0694510c0964))
+
 ## [6.18.0](https://github.com/blackbaud/skyux/compare/6.17.1...6.18.0) (2022-09-08)
 
 

apps/ag-grid-storybook-e2e/src/integration/ag-grid-stories.component.spec.ts

@@ -18,7 +18,10 @@ describe(`ag-grid-storybook`, () => {
           .should('exist')
           .should('be.visible')
           .screenshot(
-            `aggridstoriescomponent-aggridstories--ag-grid-stories-${theme}`
+            `aggridstoriescomponent-aggridstories--ag-grid-stories-${theme}`,
+            {
+              clip: { x: 0, y: 0, width: 1300, height: 600 },
+            }
           )
           .percySnapshot(
             `aggridstoriescomponent-aggridstories--ag-grid-stories-${theme}`,
@@ -27,8 +30,8 @@ describe(`ag-grid-storybook`, () => {
               scope: '#root',
               percyCSS: `
                 /* Avoid "virtual rows" in the screenshot. */
-                :root {
-                  --viewport-height: 600px;
+                #root {
+                  height: 600px;
                 }
               `,
             }

apps/ag-grid-storybook-e2e/src/integration/data-manager.component.spec.ts

@@ -25,7 +25,10 @@ describe(`ag-grid-storybook data manager`, () => {
               .should('exist')
               .should('be.visible')
               .screenshot(
-                `datamanagercomponent-datamanager--data-manager-${domLayout}-${theme}`
+                `datamanagercomponent-datamanager--data-manager-${domLayout}-${theme}`,
+                {
+                  clip: { x: 0, y: 0, width: 1300, height: 600 },
+                }
               )
               .percySnapshot(
                 `datamanagercomponent-datamanager--data-manager-${domLayout}-${theme}`,
@@ -34,8 +37,8 @@ describe(`ag-grid-storybook data manager`, () => {
                   scope: '#root',
                   percyCSS: `
                     /* Avoid "virtual rows" in the screenshot. */
-                    :root {
-                      --viewport-height: 600px;
+                    #root {
+                      height: 600px;
                     }
                   `,
                 }

apps/ag-grid-storybook/src/app/ag-grid/ag-grid-stories.component.ts

@@ -8,7 +8,8 @@ import {
 import { SkyAgGridService, SkyCellType } from '@skyux/ag-grid';
 
 import { GridOptions } from 'ag-grid-community';
-import { BehaviorSubject } from 'rxjs';
+import { BehaviorSubject, timer } from 'rxjs';
+import { first } from 'rxjs/operators';
 
 import { columnDefinitions, data } from '../shared/baseball-players-data';
 
@@ -67,7 +68,10 @@ export class AgGridStoriesComponent implements OnInit {
         },
         domLayout: this.domLayout,
         onGridReady: () => {
-          this.ready.next(true);
+          // Delay to allow the grid to render before capturing the screenshot.
+          timer(800)
+            .pipe(first())
+            .subscribe(() => this.ready.next(true));
         },
       },
     });

apps/ag-grid-storybook/src/app/data-manager/data-manager.component.ts

@@ -14,7 +14,8 @@ import {
 } from '@skyux/data-manager';
 
 import { GridOptions } from 'ag-grid-community';
-import { BehaviorSubject } from 'rxjs';
+import { BehaviorSubject, timer } from 'rxjs';
+import { first } from 'rxjs/operators';
 
 import { columnDefinitions, data } from '../shared/baseball-players-data';
 
@@ -152,7 +153,10 @@ export class DataManagerComponent implements OnInit {
         },
         domLayout: this.domLayout,
         onGridReady: () => {
-          this.ready.next(true);
+          // Delay to allow the grid to render before capturing the screenshot.
+          timer(800)
+            .pipe(first())
+            .subscribe(() => this.ready.next(true));
         },
       },
     });

apps/code-examples/src/app/app-routing.module.ts

@@ -115,6 +115,13 @@ const routes: Routes = [
         (m) => m.DataManagerFeatureModule
       ),
   },
+  {
+    path: 'text-editor',
+    loadChildren: () =>
+      import('./features/text-editor.module').then(
+        (m) => m.TextEditorFeatureModule
+      ),
+  },
 ];
 
 @NgModule({

apps/code-examples/src/app/app.component.html

@@ -321,6 +321,22 @@
       </li>
     </ul>
   </li>
+
+  <li>
+    Text Editor
+    <ul>
+      <li>
+        <a routerLink="text-editor/rich-text-display">Rich text display</a>
+      </li>
+      <li><a routerLink="text-editor/text-editor">Text Editor</a></li>
+      <li>
+        <a routerLink="text-editor/text-editor-inline-help"
+          >Text Editor with inline help</a
+        >
+      </li>
+    </ul>
+  </li>
+
   <li>
     Tiles
     <ul>

apps/code-examples/src/app/code-examples/forms/checkbox/basic/checkbox-demo.component.ts

@@ -8,10 +8,14 @@ import { FormBuilder, FormControl, FormGroup } from '@angular/forms';
 export class CheckboxDemoComponent implements OnInit {
   public myForm: FormGroup;
 
-  constructor(private formBuilder: FormBuilder) {}
+  #formBuilder: FormBuilder;
+
+  constructor(formBuilder: FormBuilder) {
+    this.#formBuilder = formBuilder;
+  }
 
   public ngOnInit(): void {
-    this.myForm = this.formBuilder.group({
+    this.myForm = this.#formBuilder.group({
       email: new FormControl(false),
       phone: new FormControl(false),
       text: new FormControl(false),