fix(components/lookup): rename harness filters textContent property to text to satisfy conventions (#526)

Author: Blackbaud-SteveBrush

libs/components/lookup/testing/src/autocomplete/autocomplete-harness.spec.ts

@@ -72,7 +72,7 @@ describe('Autocomplete harness', () => {
     const results = await autocompleteHarness.getSearchResults();
 
     await expectAsync(results[0].getDescriptorValue()).toBeResolvedTo('Red');
-    await expectAsync(results[0].textContent()).toBeResolvedTo('Red');
+    await expectAsync(results[0].getText()).toBeResolvedTo('Red');
   });
 
   it('should return search results text content', async () => {
@@ -113,7 +113,7 @@ describe('Autocomplete harness', () => {
 
     await autocompleteHarness.enterText('r');
     await autocompleteHarness.selectSearchResult({
-      textContent: 'Green',
+      text: 'Green',
     });
 
     await expectAsync(autocompleteHarness.getValue()).toBeResolvedTo('Green');
@@ -127,7 +127,7 @@ describe('Autocomplete harness', () => {
     // First, set a value on the autocomplete.
     await autocompleteHarness.enterText('r');
     await autocompleteHarness.selectSearchResult({
-      textContent: 'Green',
+      text: 'Green',
     });
     await expectAsync(autocompleteHarness.getValue()).toBeResolvedTo('Green');
 
@@ -157,10 +157,10 @@ describe('Autocomplete harness', () => {
 
     await expectAsync(
       autocompleteHarness.getSearchResults({
-        textContent: /invalidsearchtext/,
+        text: /invalidsearchtext/,
       })
     ).toBeRejectedWithError(
-      'Could not find search results matching filter(s): {"textContent":"/invalidsearchtext/"}'
+      'Could not find search results matching filter(s): {"text":"/invalidsearchtext/"}'
     );
   });
 
@@ -187,7 +187,7 @@ describe('Autocomplete harness', () => {
       const results = await autocompleteHarness.getSearchResults();
 
       await expectAsync(results[0].getDescriptorValue()).toBeResolvedTo('Red');
-      await expectAsync(results[0].textContent()).toBeResolvedTo('Red ID: 1');
+      await expectAsync(results[0].getText()).toBeResolvedTo('Red ID: 1');
     });
 
     it('should query child harnesses', async () => {

libs/components/lookup/testing/src/autocomplete/autocomplete-harness.ts

@@ -78,8 +78,8 @@ export class SkyAutocompleteHarness extends SkyComponentHarness {
 
     if (filters && harnesses.length === 0) {
       // Stringify the regular expression so that it's readable in the console log.
-      if (filters.textContent instanceof RegExp) {
-        filters.textContent = filters.textContent.toString();
+      if (filters.text instanceof RegExp) {
+        filters.text = filters.text.toString();
       }
 
       throw new Error(
@@ -102,7 +102,7 @@ export class SkyAutocompleteHarness extends SkyComponentHarness {
 
     const text: string[] = [];
     for (const harness of harnesses) {
-      text.push(await harness.textContent());
+      text.push(await harness.getText());
     }
 
     return text;

libs/components/lookup/testing/src/autocomplete/autocomplete-search-result-harness-filters.ts

@@ -9,5 +9,5 @@ export interface SkyAutocompleteSearchResultHarnessFilters
   /**
    * Only find instances whose content matches the given value.
    */
-  textContent?: string | RegExp;
+  text?: string | RegExp;
 }

libs/components/lookup/testing/src/autocomplete/autocomplete-search-result-harness.ts

@@ -26,8 +26,8 @@ export class SkyAutocompleteSearchResultHarness extends ComponentHarness {
     return new HarnessPredicate(
       SkyAutocompleteSearchResultHarness,
       filters
-    ).addOption('textContent', filters.textContent, async (harness, text) =>
-      HarnessPredicate.stringMatches(await harness.textContent(), text)
+    ).addOption('textContent', filters.text, async (harness, text) =>
+      HarnessPredicate.stringMatches(await harness.getText(), text)
     );
   }
 
@@ -58,9 +58,9 @@ export class SkyAutocompleteSearchResultHarness extends ComponentHarness {
   }
 
   /**
-   * Returns the text content of the search result.
+   * Returns the text of the search result.
    */
-  public async textContent(): Promise<string> {
+  public async getText(): Promise<string> {
     return (await this.host()).text();
   }
 }

libs/components/lookup/testing/src/lookup/lookup-harness.spec.ts

@@ -44,7 +44,7 @@ function testSingleSelect(dataSkyId: string) {
     const results = await lookupHarness.getSearchResults();
 
     await expectAsync(results[0].getDescriptorValue()).toBeResolvedTo('Abed');
-    await expectAsync(results[0].textContent()).toBeResolvedTo('Abed');
+    await expectAsync(results[0].getText()).toBeResolvedTo('Abed');
   });
 
   it('should select one option from the autocomplete results', async () => {
@@ -56,7 +56,7 @@ function testSingleSelect(dataSkyId: string) {
 
     await lookupHarness.enterText('d');
     await lookupHarness.selectSearchResult({
-      textContent: 'Leonard',
+      text: 'Leonard',
     });
 
     await expectAsync(lookupHarness.getValue()).toBeResolvedTo('Leonard');
@@ -312,7 +312,7 @@ describe('Lookup harness', () => {
       const results = await lookupHarness.getSearchResults();
 
       await expectAsync(results[0].getDescriptorValue()).toBeResolvedTo('Abed');
-      await expectAsync(results[0].textContent()).toBeResolvedTo(
+      await expectAsync(results[0].getText()).toBeResolvedTo(
         'Abed (Mr. Nadir)'
       );
     });