Skip to content

run-android-maestro-flows 0.1.3 #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chloe-vilain
Copy link

@chloe-vilain chloe-vilain commented Jan 13, 2025

TagCheck

What to do if the build fails?

At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.

New Pull Request Checklist

Please mark the points which you did / accept.

Note -
I noted from the Step Development Guide that installing external dependencies within a step is not preferred. Unfortunately, per the maestro documentation, there isn't an existing apt-get packaging for the maestro cli. I judged it more maintainable to use curl (the approach suggested by the maestro documentation) to pull & install the dependency, rather than manually copying down all the pertinent files at the current version and including them in my step. This is consistent with the approach taken by the iOS test runner community step: https://github.com/fepersembe/bitrise-step-maestro-ios-test-run

New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.

@bitrise-coresteps-bot
Copy link
Collaborator

Don't forget to follow semantic versioning! Breaking changes (including step inputs) should be in major versions only.

step.yml changes compared to previous version:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@ofalvai ofalvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chloe-vilain for the contribution, this is a solid step! 🚀
Just a note about macOS: at the moment, Android emulators don't run on macOS machines because of a limitation in nested virtualization. But we expect this to be resolved in the future, so I'm okay with this step handling both macOS and Linux dependencies, I think it's the future-proof way!

@ofalvai
Copy link
Contributor

ofalvai commented Jan 28, 2025

Oh, one for thing before I can merge: the CLI signature is missing, or maybe you signed it with another email address than what the git commit contains.

@lpusok
Copy link
Contributor

lpusok commented Mar 5, 2025

@chloe-vilain can you proceed with the CLI signature or should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants