-
Notifications
You must be signed in to change notification settings - Fork 95
Restore libbitcoinconsensus #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: __branch_29
Are you sure you want to change the base?
Conversation
This reverts commit e0287bc.
This reverts commit 80f8b92 (bitcoin#29648)
This reverts commit 25dc87e (bitcoin#29189)
With CMake, the default is to build static libraries instead of shared libraries, but libbitcoinconsensus has always been intended to be used as a shared library. People who want to build libbitcoinconsensus should probably build it separately, with BUILD_SHARED_LIBS also
Testing Report
let me know if there is anything else i can help with on this review |
Maybe my build dir is just broken? What's the cmake equivalent of |
rm -rf build 😂. (Or whatever your build directory is…) |
@bigshiny90 yep, that fixed it! This PR works great then. ACK |
yeah, i think there IS an arg with cmake to do it, just not as easy as the rm -rf.. |
Actual code unchanged, but build significantly reworked for CMake