Skip to content

Restore libbitcoinconsensus #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: __branch_29
Choose a base branch
from

Conversation

luke-jr
Copy link
Collaborator

@luke-jr luke-jr commented May 24, 2025

Actual code unchanged, but build significantly reworked for CMake

luke-jr added 8 commits May 24, 2025 13:13
With CMake, the default is to build static libraries instead of shared libraries, but libbitcoinconsensus has always been intended to be used as a shared library.
People who want to build libbitcoinconsensus should probably build it separately, with BUILD_SHARED_LIBS also
@luke-jr luke-jr mentioned this pull request May 24, 2025
18 tasks
@luke-jr luke-jr added the rebase Existing Knots patches, rebased for the latest codebase label May 24, 2025
@luke-jr luke-jr added this to the 29.0 milestone May 24, 2025
@bigshiny90
Copy link

Testing Report
Tested on: Ubuntu 22.04, GCC 11.4.0

  • ✅ Builds successfully with -DBUILD_BITCOINCONSENSUS_LIB=ON
  • ✅ Default build unchanged with -DBUILD_BITCOINCONSENSUS_LIB=OFF (default)
  • ✅ pkg-config integration functional
  • ✅ All unit tests pass
  • ✅ All functional tests pass
  • ✅ CMake changes look appropriate

let me know if there is anything else i can help with on this review

@chrisguida
Copy link

chrisguida commented Jul 1, 2025

For some reason the progress meter only goes up to 1% when I build with cmake -B build -DBUILD_BITCOINCONSENSUS_LIB=ON

But it appears to build properly when I use just cmake -B build instead.

Screenshot From 2025-07-01 11-24-49

@chrisguida
Copy link

Maybe my build dir is just broken? What's the cmake equivalent of make clean?

@bigshiny90
Copy link

Maybe my build dir is just broken? What's the cmake equivalent of make clean?

rm -rf build

😂. (Or whatever your build directory is…)

@chrisguida
Copy link

@bigshiny90 yep, that fixed it!

This PR works great then.

ACK

@bigshiny90
Copy link

@bigshiny90 yep, that fixed it!

yeah, i think there IS an arg with cmake to do it, just not as easy as the rm -rf..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebase Existing Knots patches, rebased for the latest codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants