clippy!: Box large enum variants
#277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16200528356Details
💛 - Coveralls |
7 tasks
evanlinjin
reviewed
Jul 10, 2025
This is a fix to address the clippy lints - `clippy::large_enum_variant` - `clippy::result_large_error` BREAKING: The types `LoadMismatch` and `CreateWithPersistError` are changed as a result of the now boxed variants.
ValuedMammal
force-pushed
the
fix/clippy-lints
branch
from
4b625c0 to
650c3ee
Compare
notmandatory
added a commit
that referenced
this pull request
Jul 19, 2025
14d6a62 Revert "clippy!: `Box` large enum variants" (Steve Myers) Pull request description: Reverts #277 Per discussion on team chat yesterday we need to revert this since it's a breaking change and wasn't meant to be merged until the 3.0 milestone. ValuedMammal will have to re-submit a replacement PR. ACKs for top commit: ValuedMammal: ACK 14d6a62 Tree-SHA512: 110446e6e7af41f8303d540755202b5df2c67340fd3f608756acb8335a378cf76e1e3a1c79f06c6170ed1ac0ca25413d8575c2be034882632d86a015297be285
1 task
evanlinjin
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Aug 7, 2025
418753f refactor!: `Box` changeset in `StoreErrorWithDump` (codingp110) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description Fixes #1991. As the linked issue mentions `Box`ing helps reduce memory overhead and [limits the size of enums with `StoreErrorWithDump` as variant](bitcoindevkit/bdk_wallet#277 (comment)). Breaking: The enum `StoreErrorWithDump` and the functions `load`,`dump` and `load_or_create` have been changed. ### Changelog Notice ``` Changed - `changeset` field of `StoreErrorWithDump` is now of type `Option<Box<C>>` ``` ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) ACKs for top commit: evanlinjin: ACK 418753f Tree-SHA512: c09d2b14989f62613283b728cd8f0eec849a2f3980b07e4289d55289a2834b27c32ff0fcb89706c636441c02b385fbb4a4175e93615f6e16fa2e2e0cfb0e4e26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix to address clippy lints
clippy::large_enum_variantclippy::result_large_errorBREAKING: The types
LoadMismatch, andCreateWithPersistErrorare changed as a result of the now boxed variants.fixes #245
Checklists
All Submissions:
Bugfixes: