Skip to content

Conversation

@vsn4ik
Copy link

@vsn4ik vsn4ik commented Dec 7, 2025

no-leaked-render dead link fix

@netlify
Copy link

netlify bot commented Dec 7, 2025

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit fa68ea8
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/6935def79acb760008d10318
😎 Deploy Preview https://deploy-preview-3602--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en src/content/docs/linter/javascript/sources.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

Documentation updates to the linter rules guide adjusting references to the jsx-no-leaked-render rule. The sources mapping table for eslint-plugin-react has been updated to include the new jsx-no-leaked-render entry with its corresponding Biome rule name (noLeakedRender). The rule documentation file has been updated to reference the correct external source link. These changes are purely informational and contain no functional impact.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a dead link in the no-leaked-render documentation by updating it to the correct jsx-no-leaked-render reference.
Description check ✅ Passed The description is directly related to the changeset, referring to the dead link fix that is evident in both documentation files modified.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2f4fab and fa68ea8.

📒 Files selected for processing (2)
  • src/content/docs/linter/javascript/sources.mdx (1 hunks)
  • src/content/docs/linter/rules/no-leaked-render.mdx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - biomejs
  • GitHub Check: Header rules - biomejs
  • GitHub Check: Pages changed - biomejs
🔇 Additional comments (2)
src/content/docs/linter/rules/no-leaked-render.mdx (1)

23-23: ✓ Dead link corrected.

The external reference has been properly updated from react/no-leaked-render (dead link) to react/jsx-no-leaked-render with the correct URL. The change aligns with the sources mapping update in the companion file.

src/content/docs/linter/javascript/sources.mdx (1)

345-345: ✓ Mapping entry added correctly.

The new jsx-no-leaked-rendernoLeakedRender mapping has been added to the eslint-plugin-react table in the correct alphabetical position. The entry follows the established format and aligns with the documentation update in the companion file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@siketyan siketyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated from code in the biomejs/biome repository. Can you submit a pull request there instead?
https://github.com/biomejs/biome/blob/7a997b9df8026f52e8763067a2f1cf14c6862032/crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs#L93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants