fix(playground): unexpected "Not supported" output #2664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
siketyan
changed the title
Contributor
|
Not the first time this has happened, I've run into this footgun before. |
Member
Author
|
The type mismatch will be fixed in biomejs/biome#6781 |
Member
Author
|
I have already merged the fix for the type mismatch, closing this workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FileFeaturesResult.featuresSupportedis defined as{ [K in FeatureKind]?: SupportKind }but actually it's aMapobject. Reverted some changes and addedts-expect-errorfor now. I'll fix the type definition later to match the actual value.