Skip to content

fix: recognize format_range and format_on_type as Format capabilities… #8213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyc3 merged 4 commits into from
Nov 22, 2025
Merged

fix: recognize format_range and format_on_type as Format capabilities… #8213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fefc03b
fix: recognize format_range and format_on_type as Format capabilities…
ruidosujeira Nov 22, 2025
e56ec00
Merge branch 'main' into fix/8209-jsonc-range-formatting
ruidosujeira Nov 22, 2025
c8569df
fix(service): remove redundant comments around formatting capability …
ruidosujeira Nov 22, 2025
b8de2c6
chore(changeset): add patch note for recognizing range/on-type format…
ruidosujeira Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/recognize-format-capabilities.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed #8209: Recognized formatting capability when either range or on-type formatting is supported, not only full-file formatting. This ensures editors and the language server correctly detect formatting support in files like JSONC.
5 changes: 4 additions & 1 deletion crates/biome_service/src/workspace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,10 @@ impl FeaturesSupported {
/// Adds the features that are enabled in `capabilities` to this result.
#[inline]
pub fn with_capabilities(mut self, capabilities: &Capabilities) -> Self {
if capabilities.formatter.format.is_some() {
if capabilities.formatter.format.is_some()
|| capabilities.formatter.format_range.is_some()
|| capabilities.formatter.format_on_type.is_some()
{
self.insert(FeatureKind::Format, SupportKind::Supported);
}
if capabilities.analyzer.lint.is_some() {
Expand Down