-
-
Notifications
You must be signed in to change notification settings - Fork 794
ci: use faster runners on depot #7115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Caution Review failedThe pull request is closed. WalkthroughThis update removes the custom "Free Disk Space" GitHub Action and all its invocations across multiple workflow files. It also revises runner labels throughout the CI/CD workflows, consolidates tool installations into existing setup steps, and clarifies runner requirements with comments, without altering job logic or workflow control flow. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant Runner
participant SetupAction
participant ToolBinary
Workflow->>Runner: Selects runner (updated label)
Workflow->>SetupAction: Runs setup (e.g., Rust, Node)
SetupAction->>ToolBinary: Installs required binaries (e.g., hyperfine, cargo-udeps)
Note over Workflow, Runner: No 'Free Disk Space' step invoked
Workflow->>Runner: Proceeds with remaining job steps
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Larger runners have larger disk space, so I think we don't need to cleanup anymore.
Summary
Use faster runners (e.g. 16 cores) on heavy jobs, or use smaller runners (e.g. 2 cores) on lightweight jobs.
Test Plan
N/A
Docs
N/A