Skip to content

Conversation

@siketyan
Copy link
Member

@siketyan siketyan commented Aug 5, 2025

Summary

Use faster runners (e.g. 16 cores) on heavy jobs, or use smaller runners (e.g. 2 cores) on lightweight jobs.

Test Plan

N/A

Docs

N/A

@siketyan siketyan self-assigned this Aug 5, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2025

⚠️ No Changeset found

Latest commit: de7077b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update removes the custom "Free Disk Space" GitHub Action and all its invocations across multiple workflow files. It also revises runner labels throughout the CI/CD workflows, consolidates tool installations into existing setup steps, and clarifies runner requirements with comments, without altering job logic or workflow control flow.

Changes

Cohort / File(s) Change Summary
Remove Free Disk Space Action
.github/actions/free-disk-space/action.yaml
Deleted the composite GitHub Action for freeing disk space on runners.
Remove Free Disk Space Step from Workflows
.github/workflows/autofix.yml, .github/workflows/main.yml, .github/workflows/parser_conformance.yml, .github/workflows/pull_request.yml, .github/workflows/pull_request_js.yml, .github/workflows/pull_request_node.yml
Removed all steps invoking the local "Free Disk Space" action from these workflows.
Update Runner Labels
.github/workflows/beta.yml, .github/workflows/label-issue.yaml, .github/workflows/main.yml, .github/workflows/preview.yml, .github/workflows/pull_request.yml, .github/workflows/pull_request_js.yml, .github/workflows/pull_request_markdown.yml, .github/workflows/release.yml, .github/workflows/release_cli.yml, .github/workflows/release_js_api.yml, .github/workflows/repository_dispatch.yml
Changed runner labels to new or more specific variants (e.g., adding/removing -16, -small, or updating OS versions).
Consolidate Tool Installation
.github/workflows/bench_cli.yml, .github/workflows/pull_request.yml, .github/workflows/main.yml
Shifted installation of tools like hyperfine and cargo-udeps into existing setup actions, removing separate install steps.
Runner Requirement Comments
.github/workflows/release.yml, .github/workflows/release_cli.yml, .github/workflows/release_js_api.yml, .github/workflows/preview.yml
Added clarifying comments to certain jobs indicating the need for GitHub-hosted runners for provenance.

Sequence Diagram(s)

sequenceDiagram
    participant Workflow
    participant Runner
    participant SetupAction
    participant ToolBinary

    Workflow->>Runner: Selects runner (updated label)
    Workflow->>SetupAction: Runs setup (e.g., Rust, Node)
    SetupAction->>ToolBinary: Installs required binaries (e.g., hyperfine, cargo-udeps)
    Note over Workflow, Runner: No 'Free Disk Space' step invoked
    Workflow->>Runner: Proceeds with remaining job steps
Loading

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22f61a7 and de7077b.

📒 Files selected for processing (17)
  • .github/actions/free-disk-space/action.yaml (0 hunks)
  • .github/workflows/autofix.yml (0 hunks)
  • .github/workflows/bench_cli.yml (1 hunks)
  • .github/workflows/beta.yml (4 hunks)
  • .github/workflows/label-issue.yaml (1 hunks)
  • .github/workflows/main.yml (4 hunks)
  • .github/workflows/parser_conformance.yml (0 hunks)
  • .github/workflows/preview.yml (4 hunks)
  • .github/workflows/pull_request.yml (2 hunks)
  • .github/workflows/pull_request_js.yml (1 hunks)
  • .github/workflows/pull_request_markdown.yml (1 hunks)
  • .github/workflows/pull_request_node.yml (0 hunks)
  • .github/workflows/pull_request_title_lint.yaml (1 hunks)
  • .github/workflows/release.yml (5 hunks)
  • .github/workflows/release_cli.yml (4 hunks)
  • .github/workflows/release_js_api.yml (2 hunks)
  • .github/workflows/repository_dispatch.yml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/faster-runners

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Larger runners have larger disk space, so I think we don't need to cleanup anymore.

@siketyan siketyan merged commit 2ec91e3 into main Aug 5, 2025
3 of 4 checks passed
@siketyan siketyan deleted the ci/faster-runners branch August 5, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants