Skip to content

Conversation

@siketyan
Copy link
Member

@siketyan siketyan commented Jul 5, 2025

Summary

Fixed a regression from #6662 that broke the playground. cc @arendjr

The FileFeaturesResult struct has changed in the PR, but it is also exposed to the WASM API and caused a type mismatch. I added a custom implementation of serde::Serialize, serde::Deserialize, and schemars::JsonSchema to keep it the same as before.

Test Plan

Manually tested with the playground

@siketyan siketyan requested review from a team and arendjr July 5, 2025 10:00
@siketyan siketyan self-assigned this Jul 5, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2025

⚠️ No Changeset found

Latest commit: 3c8eb7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Formatter Area: formatter A-LSP Area: language server protocol labels Jul 5, 2025
@siketyan
Copy link
Member Author

siketyan commented Jul 5, 2025

I skipped a changeset as the regression is not yet released.

@siketyan siketyan force-pushed the fix/features-supported-map branch from df230e8 to 0be200f Compare July 5, 2025 10:12
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@siketyan siketyan merged commit e366e75 into biomejs:main Jul 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Formatter Area: formatter A-LSP Area: language server protocol A-Project Area: project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants