Skip to content

Conversation

@ematipico
Copy link
Member

Summary

Part of #6657

I added capabilities to the HTML parser to parse the Astro frontmatter, only when the HtmlFileSource has the Astro variant.

Test Plan

Added different test cases

@ematipico ematipico requested review from a team July 3, 2025 11:15
@github-actions github-actions bot added A-Project Area: project A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-HTML Language: HTML and super languages labels Jul 3, 2025
@ematipico ematipico force-pushed the feat/astro-frontmatter branch from 5c39719 to a42b3e1 Compare July 3, 2025 11:16
@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2025

⚠️ No Changeset found

Latest commit: d25d18c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50611 50611 0
Passed 49294 49294 0
Failed 1317 1317 0
Panics 0 0 0
Coverage 97.40% 97.40% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6706 6706 0
Passed 2244 2244 0
Failed 4462 4462 0
Panics 0 0 0
Coverage 33.46% 33.46% 0.00%

ts/babel

Test result main count This PR count Difference
Total 822 822 0
Passed 731 731 0
Failed 91 91 0
Panics 0 0 0
Coverage 88.93% 88.93% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18784 18784 0
Passed 14412 14412 0
Failed 4372 4372 0
Panics 0 0 0
Coverage 76.72% 76.72% 0.00%

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed Performance Report

Merging #6689 will not alter performance

Comparing feat/astro-frontmatter (d25d18c) with main (af78d6d)

Summary

✅ 114 untouched benchmarks

@dyc3 dyc3 self-requested a review July 3, 2025 13:28
@dyc3 dyc3 merged commit e517994 into main Jul 3, 2025
30 checks passed
@dyc3 dyc3 deleted the feat/astro-frontmatter branch July 3, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Formatter Area: formatter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-HTML Language: HTML and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants