Skip to content

fix: binary mapping #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 7 commits into from
Jun 21, 2025
+17 −114
Merged

fix: binary mapping #6450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a521ba2
fix: binary mapping
ematipico Jun 21, 2025
b7b5274
pnpm for publishing
ematipico Jun 21, 2025
1e1fffd
feedback
ematipico Jun 21, 2025
3a653a5
restore old script usage
ematipico Jun 21, 2025
c1fd9d0
use npm
ematipico Jun 21, 2025
586ec3b
fix json
ematipico Jun 21, 2025
68452a1
Update packages/@biomejs/cli-win32-arm64/package.json
ematipico Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-sheep-mix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed an issue where the binary wasn't correctly mapped.
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,11 @@ jobs:
git restore packages/@biomejs/wasm-nodejs/package.json
git restore packages/@biomejs/wasm-web/package.json

- name: Copy binaries
run: node packages/@biomejs/biome/scripts/copy-binaries.mjs
- name: Generate npm packages
run: node packages/@biomejs/biome/scripts/generate-packages.mjs

- name: Publish npm packages as latest
run: for package in packages/@biomejs/*; do if [ $package != "packages/@biomejs/js-api" ]; then npm publish $package --tag latest --access public --provenance; fi; done
run: for package in packages/@biomejs/*; do if [ $package != "packages/@biomejs/js-api" ]; then npm publish $package --tag latest --access public --provenance; fi; done
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand Down Expand Up @@ -398,7 +398,7 @@ jobs:
run: pnpm install --frozen-lockfile

- name: Publish npm package as latest
run: npm publish packages/@biomejs/js-api --tag latest --access public --provenance
run: pnpm publish packages/@biomejs/js-api --no-git-checks --tag latest --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Member

@siketyan siketyan Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, you can still enable provenance in pnpm by environment variable.

Suggested change
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: true


Expand Down
78 changes: 0 additions & 78 deletions packages/@biomejs/biome/scripts/copy-binaries.mjs
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions packages/@biomejs/cli-darwin-arm64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}
5 changes: 1 addition & 4 deletions packages/@biomejs/cli-darwin-x64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}
5 changes: 1 addition & 4 deletions packages/@biomejs/cli-linux-arm64-musl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}
5 changes: 1 addition & 4 deletions packages/@biomejs/cli-linux-arm64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}
5 changes: 1 addition & 4 deletions packages/@biomejs/cli-linux-x64-musl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}
5 changes: 1 addition & 4 deletions packages/@biomejs/cli-linux-x64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}
5 changes: 1 addition & 4 deletions packages/@biomejs/cli-win32-arm64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}
5 changes: 1 addition & 4 deletions packages/@biomejs/cli-win32-x64/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,5 @@
],
"publishConfig": {
"provenance": true
},
"files": [
"bin/biome"
]
}
}