fix(resolver): resolve type definitions for JavaScript files #6343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes to the resolver that allow for resolving type definitions for files that are explicitly referenced with a JavaScript extension. For instance, when a file is explicitly imported as
types.js, we can still pull the types fromtypes.d.tsinstead. This is relied upon by some NPM packages such asswr.As part of this, the resolver API has changed slightly, and
.d.tsextensions should no longer be supplied by the consumer of the resolver.I can confirm that with this change, some imports from the
swrpackage are now recognised correctly, improving inference. The result from theuseSWRConfig()call in the test is not yet inferred though.I've also spotted a few opportunities to avoid allocations inside the resolver, so we don't allocate a new path for every extension we try anymore.
Test Plan
Tests added.