fix(cli): prevent panic when searching across different file types #6192
+166
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siketyan
approved these changes
Jun 2, 2025
| // Default to JavaScript when no language is specified | ||
| &GritTargetLanguage::JsTargetLanguage(JsTargetLanguage) | ||
| } | ||
| _ => return Ok(FileStatus::Ignored), // unreachable |
Member
There was a problem hiding this comment.
Suggested change
| _ => return Ok(FileStatus::Ignored), // unreachable | |
| _ => unreachable!(), |
Contributor
There was a problem hiding this comment.
I'd prefer to keep it as is, as otherwise we'd panic again if it turns out we made a mistake (either now or after a refactor).
arendjr
approved these changes
Jun 2, 2025
| // Default to JavaScript when no language is specified | ||
| &GritTargetLanguage::JsTargetLanguage(JsTargetLanguage) | ||
| } | ||
| _ => return Ok(FileStatus::Ignored), // unreachable |
Contributor
There was a problem hiding this comment.
I'd prefer to keep it as is, as otherwise we'd panic again if it turns out we made a mistake (either now or after a refactor).
Co-authored-by: Naoki Ikeguchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5979
This PR updates the
biome searchcommand to check the file type and pattern language before performing a search.By default, biome search assumes JavaScript, but it would previously panic if a CSS file was included in the search targets.
With this change, the command no longer panics.
Test Plan
I also tested on the repro: https://github.com/Sjlver/biome-repro-1747046861198