refactor(js_type_info): avoid allocating a String upon number parsing #6176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
L-JavaScript
arendjr
approved these changes
May 30, 2025
Contributor
arendjr
left a comment
arendjr
left a comment
There was a problem hiding this comment.
Thanks!
I'm afraid to_f64() never gets called atm, but I expect we'll use it again at some point in the future, which is why I didn't want to throw it away just yet. So I hope your improvement will still provide some benefit then 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a very small change that basically check if the number has a numeric separator
_before callingreplacethat allocates a string.Also, I improved the prefix detection using a match.
Test Plan
No regression should be observed.