perf(core): don't save content of d.ts files

[ematipico]

Summary

• Fixes an issue where the ordering of diagnostics wasn't predictable
• Reduce the usage of memory by not saving the content of .d.ts files that belong to node_modules inside the Workspace

Test Plan

CI should stay green. Updated the existing snapshots.

[Conaclos]

Have you run any tests to see if this would save memory on a large project?

[arendjr]

Maybe an expect() with a message that could point us in the right direction?

[arendjr]

Why wouldn't we want to watch it? This is the only place we set it to true (outside tests).

[ematipico]

ooops this is a leftover :D

[arendjr]

🙏

[ematipico]

Have you run any tests to see if this would save memory on a large project?

Yes, I tried a lot, and it does help somewhat; however, I believe the majority of memory consumption is due to the module graph and type inference.

The thing is, at the moment, we compute all .d.ts files inside node_modules, even the ones that belong to indirect dependencies. I talked with @arendjr about it, and we agreed with this approach for the time being, and then optimise it later while our inference system and infrastructure gets better.

The main challenge is re-exports, where dependencies can export their dependencies, and this is a very common pattern.

I will update the FAQ section to make sure users are aware of the current works and what to expect.

[arendjr]

I guess that test failure makes sense, you'll have to query the module graph instead to verify its presence.