refactor: abstract/reuse react component detection logic #6124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up refactoring after discussion here: #6053 (comment)
What was done:
react::componentsmod.JsExport::get_exported_itemswas improved to return proper values in all cases, not just in a few pre-selected ones.noNestedComponentDefinitionsanduseComponentExportOnlyModuleswere simplified.useComponentExportOnlyModulestests were removed.Please take a look, @dyc3.
Test Plan
Tests are included