fix(formatter): keep newline before semicolon in the previous statement #6048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6029
The Automatic Semicolon Insertion (ASI) has some exceptions where we need to put a semicolon anyway to disambiguate the syntax. When we prefer to use ASI and omit semicolons if possible, we put a required semicolon just before the next statement.
In this case, the text range of the previous statement ends at the semicolon we put. Then the distance of two statements will be zero, which leads the intended newline to be removed incorrectly.
To fix this issue, the formatter of
JsExpressionStatementnow measures the distance between the semicolon and the previous token of the semicolon and writes a newline if the distance is greater than one line.Test Plan
Added a snapshot test.