Skip to content

fix(lint/noUselessEscapeInString): flag useless escapes after skipping \${ in template literals #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Conaclos merged 1 commit into from
May 17, 2025
Merged

fix(lint/noUselessEscapeInString): flag useless escapes after skipping \${ in template literals #6044

Conaclos merged 1 commit into from
May 17, 2025

Conversation

@lucasweng
Copy link
Contributor

@lucasweng lucasweng commented May 17, 2025

Summary

Fixed #6042. The rule now reports useless escapes after skipping \${ in template literals.

Test Plan

  • Added more tests for template literals with \${.
  • Existing tests pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels May 17, 2025
@lucasweng lucasweng mentioned this pull request May 17, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented May 17, 2025

CodSpeed Performance Report

Merging #6044 will not alter performance

Comparing lucasweng:fix/noUselessEscapeInString (01c962c) with main (3e8fbee)

Summary

✅ 94 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 html_formatter[index_1033418810622582172.html] N/A 462.7 µs N/A

@dyc3 dyc3 requested a review from Conaclos May 17, 2025 03:20
Conaclos
Conaclos approved these changes May 17, 2025
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Conaclos Conaclos merged commit a82a1f2 into biomejs:main May 17, 2025
13 checks passed
@lucasweng lucasweng deleted the fix/noUselessEscapeInString branch May 17, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Conaclos Conaclos Conaclos approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucasweng @Conaclos