fix(analyzer): fix plugin diagnostic suppression + resolve double diagnostics #6035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
arendjr
changed the title
ematipico
approved these changes
May 16, 2025
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Awesome! I can see from the snapshots that a diagnostic is gone. I suppose we didn't check me thoroughly
arendjr
force-pushed
the
fix-plugin-suppression
branch
from
8e36ba5 to
ce4c73b
Compare
Contributor
Author
|
Yes, you're right. I must've checked one in with a duplicated diagnostic 🙈 |
CodSpeed Performance ReportMerging #6035 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6031:
biome checkcalls the analyzer twice, once for formatting and once for linting. But it handed the linter plugins to both invocations, causing them to run twice. Worse, in the formatting invocation, the suppressions didn't work either.Also fixes an issue that could cause certain Grit queries to report double diagnostics.
Test Plan
Test added.