feat(cli): support rule without group in --only and --skip
#6004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
reviewed
May 13, 2025
Conaclos
force-pushed
the
conaclos/only-skip-rule-without-group-name
branch
2 times, most recently
from
7eb32af to
80f79fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pr adds the capability of passing only the rule name in
--onlyand--skipCLI options.Previously
--only=<rule-name>was rejected.You had to add the group name:
--only=<group-name>/<rule-name>.--only=<rule-name>is now accepted.I took the opportunity of improving the validation.
We now reject using the
lint/prefix for an assist action/group and theassist/prefix for a lint rule/group.Test Plan
I updated the snapshots.