refactor(migrate): don't unpromote useNamingConvention #5994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
force-pushed
the
conaclos/ruleMover-useNamingConvention-exception
branch
from
c45419b to
4f689f9
Compare
Conaclos
force-pushed
the
conaclos/ruleMover-useNamingConvention-exception
branch
from
4f689f9 to
9ea5329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
useNamingConventionis associated to two groups:stylefor the JS rule andniurseryfor the GraphQL rule.This breaks the assumption that a rule is associated to a single group.
This leads the rule mover to unpromote
style/useNamingConventiontonursery/useNamingConvention.Unfortunately we can promote the GraphQL rule because the rule options are incompatible at the moment.
As a temporary fix of the rule mover, I added a hardcoded exception for
useNamingConvention.Test Plan
I updated the snapshots