refactor(migrate): handle already migrated rules #5965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
force-pushed
the
conaclos/rule-mover-handle-duplicas
branch
from
71b59a1 to
252f29c
Compare
ematipico
approved these changes
May 12, 2025
Conaclos
force-pushed
the
conaclos/rule-mover-handle-duplicas
branch
from
252f29c to
229825b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve the rule mover migration by handling already migrated rules and migration of several rules with the same name.
Basically, if the rule was already migrated, we just remove the old one.
This should solve an issue we have with a repository in the ecosystem-ci.
Test Plan
I added some tests.