refactor(config): remove overrides.include
#5176
Merged
+145
−1,893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
force-pushed
the
conaclos/editorconfig-includes
branch
from
f83164d to
3e6ad06
Compare
ematipico
approved these changes
Feb 23, 2025
Conaclos
force-pushed
the
conaclos/editorconfig-includes
branch
from
3e6ad06 to
23a01a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4611
Fixes #2421
Fixes #3345
This PR completely remove the
includefield of the Biome config file.I introduced the new types
OverrideGlobsandOverrideIncludesto support Editorconfig.biome_deserializealways deserialize the globs as Biome globs, while serde deserialize/serialize the two formats that allows LSP deserialization/serialization.The Editorconfig parser ignores glob patterns that generate errors.
Errors were collected but silently ignored.
We should certainly report the errors as warnings in verbose mode.
I left it for anyone interested in.
I removed out=r old glob implementation.
Also, I noted that another ambiguity about Editorconfig globs.
I updated
EditorconfigGlobto take it into account.Test Plan
I updated the tests.