🐛 noTypeOnlyImportAttributes - does not allow resolution-mode import attributes

[hanseltime]

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.18.2"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.6.0"

Biome Configuration:
  Error:                        Found an unknown key `includes`.
  Error:                        Found an unknown key `assist`.
  Error:                        Found an unknown key `noAdjacentSpacesInRegex`.
  Error:                        Found an unknown key `includes`.
  Error:                        Found an unknown key `includes`.
  Error:                        Found an unknown key `includes`.
  Status:                       Loaded with errors
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Also Tried with current beta:

CLI:
  Version:                      2.0.0-beta.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         xterm-256color
  JS_RUNTIME_VERSION:           v20.18.2
  JS_RUNTIME_NAME:              node
  NODE_PACKAGE_MANAGER:         yarn/4.6.0

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         /home/justin.hanselman/test-yarn/biome.json
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  false

Workspace:
  Open Documents:               0

What happened?

1. In a typescript project that is CommonJS (I.e. package.json that does not have "type": "module")
2. With a tsconfig that uses nodenext for module and moduleResolution
3. And an imported package that is ESM only (like chalk)
4. Try importing the chalk type in a .ts file:

import type { ChalkInstance } from "chalk" with { "resolution-mode": "import" };

If you remove the import attribute, typescript will refuse to compile since it can't find a "require" version of types, so you have to have that to import the type.

Expected result

When I ran biome format and biome lint, I expected them to work. However, both of them fail at the unskippable syntax/correctness/noTypeOnlyImportAttributes. They also don't let me use the biome-ignore syntax, so I am effectively unable to lint and format, because build support requires that I have this.

I would have expected Biome not to care if I added type-only imports with a resolution-mode import attribute.

Note: I would be willing to contribute a fix if someone can confirm that we are fine with letting import type with "resolution-mode" pass. If there are more exotic use cases, let me know.

Note 2: this was previously brought up in #2115 - but the fix that was supplied seems to only do this for .cts files which isn't guaranteed, since typescript can require this if it finds a module mismatch.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

The syntax rule is a bit strict. Its documentation (not published) highlights the following:

There is one exception: TypeScript 5.3 and above allow this in CommonJS files, e.g. files ending with the .cts extension.

This means that your file must be renamed to cts. Does that fix your issue?

[hanseltime]

Yea, I had to do this as a workaround. I would like to not keep random files as .cts in the future.

I think this really brings up 2 things:

1. Bug - the syntax rule should allow .ts files to have import attributes for type-only imports on .ts files
2. Feature - There should be a way to turn off syntax rules that are bugged - otherwise, one bug renders biome useless.

Do you agree? And if so, would you like me to work on 1 or 2? (2 would be much harder for me as a new contributor)

[ematipico]

cc @Conaclos, which implemented the rule