refactor(lint/noUselessContinue): move rule to complexity (#6068)

Author: Conaclos

.changeset/rule-promotion.md

@@ -7,6 +7,7 @@ Change the group of some rules, promote nursery rules and update the recommended
 The following rules have been moved to a new group:
 
 - [complexity/noFlatMapIdentity](https://biomejs.dev/linter/rules/no-flat-map-identity)
+- [complexity/noUselessContinue](https://biomejs.dev/linter/rules/no-useless-continue)
 - [complexity/useNumericLiterals](https://biomejs.dev/linter/rules/use-numeric-literals)
 - [correctness/useValidTypeof](https://biomejs.dev/linter/rules/use-valid-typeof)
 - [performance/noNamespaceImport](https://biomejs.dev/linter/rules/no-namespace-import/)

.changeset/six-friends-lick.md

@@ -2,4 +2,4 @@
 "@biomejs/biome": patch
 ---
 
-Renamed the rule `noDuplicatedFields` to `noDuplicateFields`. This rules belongs to the `nursery` group, so no migration is provided.
+Renamed the rule `noDuplicatedFields` to `noDuplicateFields`. Run the command `biome migrate` to update your configuration.

.changeset/witty-plants-ring.md

@@ -2,6 +2,4 @@
 "@biomejs/biome": major
 ---
 
-Renamed the rule `noMultipleSpacesInRegularExpressionLiterals` to `noAdjacentSpacesInRegex`.
-
-Use `biome migrate --write` to update the configuration.
+Renamed the rule `noMultipleSpacesInRegularExpressionLiterals` to `noAdjacentSpacesInRegex`. Run the command `biome migrate` to update your configuration.

crates/biome_cli/tests/snapshots/main_commands_rage/with_linter_configuration.snap

@@ -75,6 +75,7 @@ Linter:
     complexity/noThisInStatic
     complexity/noUselessCatch
     complexity/noUselessConstructor
+    complexity/noUselessContinue
     complexity/noUselessEmptyExport
     complexity/noUselessEscapeInRegex
     complexity/noUselessFragments

crates/biome_cli/tests/snapshots/main_configuration/incorrect_rule_name.snap

@@ -92,7 +92,6 @@ biome.json:6:13 deserialize ━━━━━━━━━━━━━━━━━
   - noUnusedLabels
   - noUnusedPrivateClassMembers
   - noUnusedVariables
-  - noUselessContinue
   - noVoidElementsWithChildren
   - noVoidTypeReturn
   - useExhaustiveDependencies

crates/biome_configuration/src/analyzer/linter/rules.rs

@@ -61,6 +61,7 @@ define_categories! {
     "lint/complexity/noThisInStatic": "https://biomejs.dev/linter/rules/no-this-in-static",
     "lint/complexity/noUselessCatch": "https://biomejs.dev/linter/rules/no-useless-catch",
     "lint/complexity/noUselessConstructor": "https://biomejs.dev/linter/rules/no-useless-constructor",
+    "lint/complexity/noUselessContinue": "https://biomejs.dev/linter/rules/no-useless-continue",
     "lint/complexity/noUselessEmptyExport": "https://biomejs.dev/linter/rules/no-useless-empty-export",
     "lint/complexity/noUselessEscapeInRegex": "https://biomejs.dev/linter/rules/no-useless-escape-in-regex",
     "lint/complexity/noUselessFragments": "https://biomejs.dev/linter/rules/no-useless-fragments",
@@ -132,7 +133,6 @@ define_categories! {
     "lint/correctness/noUnusedLabels": "https://biomejs.dev/linter/rules/no-unused-labels",
     "lint/correctness/noUnusedPrivateClassMembers": "https://biomejs.dev/linter/rules/no-unused-private-class-members",
     "lint/correctness/noUnusedVariables": "https://biomejs.dev/linter/rules/no-unused-variables",
-    "lint/correctness/noUselessContinue": "https://biomejs.dev/linter/rules/no-useless-continue",
     "lint/correctness/noVoidElementsWithChildren": "https://biomejs.dev/linter/rules/no-void-elements-with-children",
     "lint/correctness/noVoidTypeReturn": "https://biomejs.dev/linter/rules/no-void-type-return",
     "lint/correctness/useExhaustiveDependencies": "https://biomejs.dev/linter/rules/use-exhaustive-dependencies",

crates/biome_diagnostics_categories/src/categories.rs

@@ -15,6 +15,7 @@ pub mod no_static_only_class;
 pub mod no_this_in_static;
 pub mod no_useless_catch;
 pub mod no_useless_constructor;
+pub mod no_useless_continue;
 pub mod no_useless_empty_export;
 pub mod no_useless_escape_in_regex;
 pub mod no_useless_fragments;
@@ -39,4 +40,4 @@ pub mod use_regex_literals;
 pub mod use_simple_number_keys;
 pub mod use_simplified_logic_expression;
 pub mod use_while;
-declare_lint_group! { pub Complexity { name : "complexity" , rules : [self :: no_adjacent_spaces_in_regex :: NoAdjacentSpacesInRegex , self :: no_banned_types :: NoBannedTypes , self :: no_empty_type_parameters :: NoEmptyTypeParameters , self :: no_excessive_cognitive_complexity :: NoExcessiveCognitiveComplexity , self :: no_excessive_nested_test_suites :: NoExcessiveNestedTestSuites , self :: no_extra_boolean_cast :: NoExtraBooleanCast , self :: no_flat_map_identity :: NoFlatMapIdentity , self :: no_for_each :: NoForEach , self :: no_static_only_class :: NoStaticOnlyClass , self :: no_this_in_static :: NoThisInStatic , self :: no_useless_catch :: NoUselessCatch , self :: no_useless_constructor :: NoUselessConstructor , self :: no_useless_empty_export :: NoUselessEmptyExport , self :: no_useless_escape_in_regex :: NoUselessEscapeInRegex , self :: no_useless_fragments :: NoUselessFragments , self :: no_useless_label :: NoUselessLabel , self :: no_useless_lone_block_statements :: NoUselessLoneBlockStatements , self :: no_useless_rename :: NoUselessRename , self :: no_useless_string_concat :: NoUselessStringConcat , self :: no_useless_string_raw :: NoUselessStringRaw , self :: no_useless_switch_case :: NoUselessSwitchCase , self :: no_useless_ternary :: NoUselessTernary , self :: no_useless_this_alias :: NoUselessThisAlias , self :: no_useless_type_constraint :: NoUselessTypeConstraint , self :: no_useless_undefined_initialization :: NoUselessUndefinedInitialization , self :: no_void :: NoVoid , self :: use_arrow_function :: UseArrowFunction , self :: use_date_now :: UseDateNow , self :: use_flat_map :: UseFlatMap , self :: use_literal_keys :: UseLiteralKeys , self :: use_numeric_literals :: UseNumericLiterals , self :: use_optional_chain :: UseOptionalChain , self :: use_regex_literals :: UseRegexLiterals , self :: use_simple_number_keys :: UseSimpleNumberKeys , self :: use_simplified_logic_expression :: UseSimplifiedLogicExpression , self :: use_while :: UseWhile ,] } }
+declare_lint_group! { pub Complexity { name : "complexity" , rules : [self :: no_adjacent_spaces_in_regex :: NoAdjacentSpacesInRegex , self :: no_banned_types :: NoBannedTypes , self :: no_empty_type_parameters :: NoEmptyTypeParameters , self :: no_excessive_cognitive_complexity :: NoExcessiveCognitiveComplexity , self :: no_excessive_nested_test_suites :: NoExcessiveNestedTestSuites , self :: no_extra_boolean_cast :: NoExtraBooleanCast , self :: no_flat_map_identity :: NoFlatMapIdentity , self :: no_for_each :: NoForEach , self :: no_static_only_class :: NoStaticOnlyClass , self :: no_this_in_static :: NoThisInStatic , self :: no_useless_catch :: NoUselessCatch , self :: no_useless_constructor :: NoUselessConstructor , self :: no_useless_continue :: NoUselessContinue , self :: no_useless_empty_export :: NoUselessEmptyExport , self :: no_useless_escape_in_regex :: NoUselessEscapeInRegex , self :: no_useless_fragments :: NoUselessFragments , self :: no_useless_label :: NoUselessLabel , self :: no_useless_lone_block_statements :: NoUselessLoneBlockStatements , self :: no_useless_rename :: NoUselessRename , self :: no_useless_string_concat :: NoUselessStringConcat , self :: no_useless_string_raw :: NoUselessStringRaw , self :: no_useless_switch_case :: NoUselessSwitchCase , self :: no_useless_ternary :: NoUselessTernary , self :: no_useless_this_alias :: NoUselessThisAlias , self :: no_useless_type_constraint :: NoUselessTypeConstraint , self :: no_useless_undefined_initialization :: NoUselessUndefinedInitialization , self :: no_void :: NoVoid , self :: use_arrow_function :: UseArrowFunction , self :: use_date_now :: UseDateNow , self :: use_flat_map :: UseFlatMap , self :: use_literal_keys :: UseLiteralKeys , self :: use_numeric_literals :: UseNumericLiterals , self :: use_optional_chain :: UseOptionalChain , self :: use_regex_literals :: UseRegexLiterals , self :: use_simple_number_keys :: UseSimpleNumberKeys , self :: use_simplified_logic_expression :: UseSimplifiedLogicExpression , self :: use_while :: UseWhile ,] } }

crates/biome_js_analyze/src/lint/complexity.rs

@@ -74,7 +74,7 @@ declare_lint_rule! {
         name: "noUselessContinue",
         language: "js",
         recommended: true,
-        severity: Severity::Error,
+        severity: Severity::Information,
         fix_kind: FixKind::Safe,
     }
 }

…/lint/correctness/no_useless_continue.rs …c/lint/complexity/no_useless_continue.rscrates/biome_js_analyze/src/lint/correctness/no_useless_continue.rs renamed to crates/biome_js_analyze/src/lint/complexity/no_useless_continue.rs crates/biome_js_analyze/src/lint/correctness/no_useless_continue.rs renamed to crates/biome_js_analyze/src/lint/complexity/no_useless_continue.rs

@@ -35,7 +35,6 @@ pub mod no_unused_imports;
 pub mod no_unused_labels;
 pub mod no_unused_private_class_members;
 pub mod no_unused_variables;
-pub mod no_useless_continue;
 pub mod no_void_elements_with_children;
 pub mod no_void_type_return;
 pub mod use_exhaustive_dependencies;
@@ -46,4 +45,4 @@ pub mod use_jsx_key_in_iterable;
 pub mod use_valid_for_direction;
 pub mod use_valid_typeof;
 pub mod use_yield;
-declare_lint_group! { pub Correctness { name : "correctness" , rules : [self :: no_children_prop :: NoChildrenProp , self :: no_const_assign :: NoConstAssign , self :: no_constant_condition :: NoConstantCondition , self :: no_constant_math_min_max_clamp :: NoConstantMathMinMaxClamp , self :: no_constructor_return :: NoConstructorReturn , self :: no_empty_character_class_in_regex :: NoEmptyCharacterClassInRegex , self :: no_empty_pattern :: NoEmptyPattern , self :: no_global_object_calls :: NoGlobalObjectCalls , self :: no_inner_declarations :: NoInnerDeclarations , self :: no_invalid_builtin_instantiation :: NoInvalidBuiltinInstantiation , self :: no_invalid_constructor_super :: NoInvalidConstructorSuper , self :: no_invalid_use_before_declaration :: NoInvalidUseBeforeDeclaration , self :: no_nodejs_modules :: NoNodejsModules , self :: no_nonoctal_decimal_escape :: NoNonoctalDecimalEscape , self :: no_precision_loss :: NoPrecisionLoss , self :: no_private_imports :: NoPrivateImports , self :: no_render_return_value :: NoRenderReturnValue , self :: no_self_assign :: NoSelfAssign , self :: no_setter_return :: NoSetterReturn , self :: no_string_case_mismatch :: NoStringCaseMismatch , self :: no_switch_declarations :: NoSwitchDeclarations , self :: no_undeclared_dependencies :: NoUndeclaredDependencies , self :: no_undeclared_variables :: NoUndeclaredVariables , self :: no_unreachable :: NoUnreachable , self :: no_unreachable_super :: NoUnreachableSuper , self :: no_unsafe_finally :: NoUnsafeFinally , self :: no_unsafe_optional_chaining :: NoUnsafeOptionalChaining , self :: no_unused_function_parameters :: NoUnusedFunctionParameters , self :: no_unused_imports :: NoUnusedImports , self :: no_unused_labels :: NoUnusedLabels , self :: no_unused_private_class_members :: NoUnusedPrivateClassMembers , self :: no_unused_variables :: NoUnusedVariables , self :: no_useless_continue :: NoUselessContinue , self :: no_void_elements_with_children :: NoVoidElementsWithChildren , self :: no_void_type_return :: NoVoidTypeReturn , self :: use_exhaustive_dependencies :: UseExhaustiveDependencies , self :: use_hook_at_top_level :: UseHookAtTopLevel , self :: use_import_extensions :: UseImportExtensions , self :: use_is_nan :: UseIsNan , self :: use_jsx_key_in_iterable :: UseJsxKeyInIterable , self :: use_valid_for_direction :: UseValidForDirection , self :: use_valid_typeof :: UseValidTypeof , self :: use_yield :: UseYield ,] } }
+declare_lint_group! { pub Correctness { name : "correctness" , rules : [self :: no_children_prop :: NoChildrenProp , self :: no_const_assign :: NoConstAssign , self :: no_constant_condition :: NoConstantCondition , self :: no_constant_math_min_max_clamp :: NoConstantMathMinMaxClamp , self :: no_constructor_return :: NoConstructorReturn , self :: no_empty_character_class_in_regex :: NoEmptyCharacterClassInRegex , self :: no_empty_pattern :: NoEmptyPattern , self :: no_global_object_calls :: NoGlobalObjectCalls , self :: no_inner_declarations :: NoInnerDeclarations , self :: no_invalid_builtin_instantiation :: NoInvalidBuiltinInstantiation , self :: no_invalid_constructor_super :: NoInvalidConstructorSuper , self :: no_invalid_use_before_declaration :: NoInvalidUseBeforeDeclaration , self :: no_nodejs_modules :: NoNodejsModules , self :: no_nonoctal_decimal_escape :: NoNonoctalDecimalEscape , self :: no_precision_loss :: NoPrecisionLoss , self :: no_private_imports :: NoPrivateImports , self :: no_render_return_value :: NoRenderReturnValue , self :: no_self_assign :: NoSelfAssign , self :: no_setter_return :: NoSetterReturn , self :: no_string_case_mismatch :: NoStringCaseMismatch , self :: no_switch_declarations :: NoSwitchDeclarations , self :: no_undeclared_dependencies :: NoUndeclaredDependencies , self :: no_undeclared_variables :: NoUndeclaredVariables , self :: no_unreachable :: NoUnreachable , self :: no_unreachable_super :: NoUnreachableSuper , self :: no_unsafe_finally :: NoUnsafeFinally , self :: no_unsafe_optional_chaining :: NoUnsafeOptionalChaining , self :: no_unused_function_parameters :: NoUnusedFunctionParameters , self :: no_unused_imports :: NoUnusedImports , self :: no_unused_labels :: NoUnusedLabels , self :: no_unused_private_class_members :: NoUnusedPrivateClassMembers , self :: no_unused_variables :: NoUnusedVariables , self :: no_void_elements_with_children :: NoVoidElementsWithChildren , self :: no_void_type_return :: NoVoidTypeReturn , self :: use_exhaustive_dependencies :: UseExhaustiveDependencies , self :: use_hook_at_top_level :: UseHookAtTopLevel , self :: use_import_extensions :: UseImportExtensions , self :: use_is_nan :: UseIsNan , self :: use_jsx_key_in_iterable :: UseJsxKeyInIterable , self :: use_valid_for_direction :: UseValidForDirection , self :: use_valid_typeof :: UseValidTypeof , self :: use_yield :: UseYield ,] } }