refactor(lint): upgrade some unsafe fixes to safe fixes (#6063)

Author: Conaclos

.changeset/rule-fix.md

@@ -0,0 +1,21 @@
+---
+"@biomejs/biome": minor
+---
+
+Upgrade some unsafe fixes to safe fixes.
+
+The following rules have now a safe fix:
+
+- [noExtraBooleanCast](https://biomejs.dev/linter/rules/no-extra-boolean-cast)
+- [noNonoctalDecimalEscape](https://biomejs.dev/linter/rules/no-nonoctal-decimal-escape)
+- [noSwitchDeclarations](https://biomejs.dev/linter/rules/no-switch-declarations)
+- [noThisInStatic](https://biomejs.dev/linter/rules/no-this-in-static)
+- [noUnusedTemplateLiteral](https://biomejs.dev/linter/rules/no-unused-template-literal)
+- [noUselessContinue](https://biomejs.dev/linter/rules/no-useless-continue)
+- [noUselessElse](https://biomejs.dev/linter/rules/no-useless-else)
+- [noUselessStringConcat](https://biomejs.dev/linter/rules/no-useless-string-concat)
+- [useArrayLiterals](https://biomejs.dev/linter/rules/use-array-literals)
+- [useExponentiationOperator](https://biomejs.dev/linter/rules/use-exponentiation-operator)
+- [useNumberToFixedDigitsArgument](https://biomejs.dev/linter/rules/use-number-to-fixed-digits-argument)
+- [useNumericLiterals](https://biomejs.dev/linter/rules/use-numeric-literals)
+- [useSimplifiedLogicExpression](https://biomejs.dev/linter/rules/use-simplified-logic-expression)

crates/biome_js_analyze/src/lint/complexity/no_extra_boolean_cast.rs

@@ -61,7 +61,7 @@ declare_lint_rule! {
         sources: &[RuleSource::Eslint("no-extra-boolean-cast")],
         recommended: true,
         severity: Severity::Information,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }
 

crates/biome_js_analyze/src/lint/complexity/no_this_in_static.rs

@@ -84,7 +84,7 @@ declare_lint_rule! {
         sources: &[RuleSource::EslintMysticatea("no-this-in-static")],
         recommended: true,
         severity: Severity::Warning,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }
 

crates/biome_js_analyze/src/lint/complexity/no_useless_string_concat.rs

@@ -68,7 +68,7 @@ declare_lint_rule! {
         sources: &[RuleSource::Eslint("no-useless-concat")],
         recommended: false,
         severity: Severity::Information,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }
 

crates/biome_js_analyze/src/lint/complexity/no_useless_string_raw.rs

@@ -36,7 +36,6 @@ declare_lint_rule! {
         language: "js",
         recommended: true,
         severity: Severity::Information,
-        severity: Severity::Information,
     }
 }
 

crates/biome_js_analyze/src/lint/complexity/use_numeric_literals.rs

@@ -61,7 +61,7 @@ declare_lint_rule! {
         sources: &[RuleSource::Eslint("prefer-numeric-literals")],
         recommended: true,
         severity: Severity::Warning,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }
 

crates/biome_js_analyze/src/lint/complexity/use_simplified_logic_expression.rs

@@ -52,7 +52,7 @@ declare_lint_rule! {
         language: "js",
         recommended: false,
         severity: Severity::Information,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }
 

crates/biome_js_analyze/src/lint/correctness/no_nonoctal_decimal_escape.rs

@@ -60,7 +60,7 @@ declare_lint_rule! {
         sources: &[RuleSource::Eslint("no-nonoctal-decimal-escape")],
         recommended: true,
         severity: Severity::Error,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }
 

crates/biome_js_analyze/src/lint/correctness/no_switch_declarations.rs

@@ -76,7 +76,7 @@ declare_lint_rule! {
         sources: &[RuleSource::Eslint("no-case-declarations")],
         recommended: true,
         severity: Severity::Error,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }
 

crates/biome_js_analyze/src/lint/correctness/no_useless_continue.rs

@@ -75,7 +75,7 @@ declare_lint_rule! {
         language: "js",
         recommended: true,
         severity: Severity::Error,
-        fix_kind: FixKind::Unsafe,
+        fix_kind: FixKind::Safe,
     }
 }