Skip to content

Added option to bind light source to scroll position (also removed console logs) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cmd-kae
Copy link

@cmd-kae cmd-kae commented Apr 15, 2014

There are inline styles on the body and h1 in the mouse-follow demo to better immediately demonstrate the added option. I also removed the console logs.

@mrtdeh
Copy link

mrtdeh commented Apr 22, 2014

Fd

@benjaminbojko
Copy link
Contributor

Thanks for the contribution -- I added your fix to remove the console logs and it's in the latest versions. Regarding the scroll example: I want to keep the demos as simple as possible and all code styles consistent. It might make sense to add another scrolling demo, so if you're up for it perhaps that's a better place for that code. Actual implementation is up to the users of the library -- following the mouse is just one example to understand the concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants