update quantms-rescoring and support AalphaPeptDeep model#571
update quantms-rescoring and support AalphaPeptDeep model#571ypriverol merged 7 commits intobigbio:devfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Pull Request Overview
Updates the quantms-rescoring container to version 0.0.11 and renames MS2PiP-specific parameters to generic MS2 model parameters to support AlphaPeptDeep model integration.
- Update quantms-rescoring container from 0.0.10 to 0.0.11
- Rename ms2pip parameters to generic ms2 model parameters for broader model support
- Add new mask_modloss parameter for controlling modloss ion masking in MS2 prediction models
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/local/utils/msrescore_features/main.nf | Updates container version and implements ms2_model_dir parameter change with new mask_modloss functionality |
| nextflow.config | Renames ms2pip parameters to generic ms2 model parameters and adds mask_modloss configuration |
| nextflow_schema.json | Updates parameter schema definitions to reflect the renamed parameters and adds mask_modloss schema |
| conf/modules/modules.config | Updates module configuration to use the new ms2_model parameter name |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
User description
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).PR Type
Enhancement
Description
Update quantms-rescoring container to version 0.0.11
Rename ms2pip parameters to generic ms2 model parameters
Support AlphaPeptDeep model integration
Diagram Walkthrough
File Walkthrough
modules.config
Rename ms2pip parameter to generic ms2 modelconf/modules/modules.config
--ms2pip_modelto--ms2_modelnextflow.config
Update parameter names for generic model supportnextflow.config
ms2pip_model_dirtoms2_model_dirms2pip_modeltoms2_modelnextflow_schema.json
Update schema for renamed parametersnextflow_schema.json
main.nf
Update container version and parameter namesmodules/local/utils/msrescore_features/main.nf
ms2pip_model_dirtoms2_model_dir