Skip to content

update quantms-rescoring and support AalphaPeptDeep model#571

Merged
ypriverol merged 7 commits intobigbio:devfrom
daichengxin:dev
Jul 29, 2025
Merged

update quantms-rescoring and support AalphaPeptDeep model#571
ypriverol merged 7 commits intobigbio:devfrom
daichengxin:dev

Conversation

@daichengxin
Copy link
Collaborator

@daichengxin daichengxin commented Jul 28, 2025

User description

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the bigbio/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR Type

Enhancement


Description

  • Update quantms-rescoring container to version 0.0.11

  • Rename ms2pip parameters to generic ms2 model parameters

  • Support AlphaPeptDeep model integration


Diagram Walkthrough

flowchart LR
  A["Container Update"] --> B["Parameter Rename"]
  B --> C["AlphaPeptDeep Support"]
  C --> D["Enhanced MS2 Rescoring"]
Loading

File Walkthrough

Relevant files
Configuration changes
modules.config
Rename ms2pip parameter to generic ms2 model                         

conf/modules/modules.config

  • Update parameter name from --ms2pip_model to --ms2_model
+1/-1     
nextflow.config
Update parameter names for generic model support                 

nextflow.config

  • Rename ms2pip_model_dir to ms2_model_dir
  • Rename ms2pip_model to ms2_model
+2/-2     
nextflow_schema.json
Update schema for renamed parameters                                         

nextflow_schema.json

  • Update schema to reflect parameter name changes
  • Change description to generic ms2 prediction model
+3/-3     
Enhancement
main.nf
Update container version and parameter names                         

modules/local/utils/msrescore_features/main.nf

  • Update container to quantms-rescoring:0.0.11
  • Change parameter from ms2pip_model_dir to ms2_model_dir
+3/-3     

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Parameter Consistency

The parameter name change from ms2pip_model to ms2_model should be verified to ensure all references are updated consistently across the codebase and that the underlying tool supports this parameter name.

"--ms2_model ${params.ms2_model}",
"--calibration_set_size ${params.calibration_set_size}",
Container Update

The container version update from 0.0.10 to 0.0.11 should be validated to ensure compatibility with the parameter changes and that the new version supports AlphaPeptDeep model integration as mentioned in the PR description.

'oras://ghcr.io/bigbio/quantms-rescoring-sif:0.0.11' :
'ghcr.io/bigbio/quantms-rescoring:0.0.11' }"

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jul 28, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@ypriverol ypriverol requested review from Copilot and ypriverol July 28, 2025 14:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the quantms-rescoring container to version 0.0.11 and renames MS2PiP-specific parameters to generic MS2 model parameters to support AlphaPeptDeep model integration.

  • Update quantms-rescoring container from 0.0.10 to 0.0.11
  • Rename ms2pip parameters to generic ms2 model parameters for broader model support
  • Add new mask_modloss parameter for controlling modloss ion masking in MS2 prediction models

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
modules/local/utils/msrescore_features/main.nf Updates container version and implements ms2_model_dir parameter change with new mask_modloss functionality
nextflow.config Renames ms2pip parameters to generic ms2 model parameters and adds mask_modloss configuration
nextflow_schema.json Updates parameter schema definitions to reflect the renamed parameters and adds mask_modloss schema
conf/modules/modules.config Updates module configuration to use the new ms2_model parameter name

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ypriverol ypriverol merged commit 3ab49c8 into bigbio:dev Jul 29, 2025
101 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants