Skip to content

support pmultiqc 0.0.31#570

Merged
ypriverol merged 2 commits intobigbio:devfrom
yueqixuan:dev
Jul 24, 2025
Merged

support pmultiqc 0.0.31#570
ypriverol merged 2 commits intobigbio:devfrom
yueqixuan:dev

Conversation

@yueqixuan
Copy link
Contributor

@yueqixuan yueqixuan commented Jul 24, 2025

User description

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the bigbio/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR Type

Enhancement


Description

  • Update pmultiqc container version from 0.0.28 to 0.0.30

  • Modify multiqc configuration for new pmultiqc version

  • Add support for diann_report_parquet output format

  • Disable plot exports in multiqc configuration


Diagram Walkthrough

flowchart LR
  A["pmultiqc 0.0.28"] --> B["pmultiqc 0.0.30"]
  B --> C["Updated Configuration"]
  C --> D["New Parquet Support"]
  C --> E["Disabled Plot Exports"]
Loading

File Walkthrough

Relevant files
Configuration changes
multiqc_config.yml
Update multiqc configuration for pmultiqc 0.0.30                 

assets/multiqc_config.yml

  • Change export_plots from true to false
  • Update sp section prefixes from quantms/ to pmultiqc/
  • Add new pmultiqc/diann_report_parquet configuration
  • Rename diann_report to diann_report_tsv
+12/-9   
Dependencies
main.nf
Upgrade pmultiqc container to version 0.0.30                         

modules/local/pmultiqc/main.nf

  • Update container version from 0.0.28 to 0.0.30
  • Remove optional plots output channel
+2/-3     
Enhancement
dia.nf
Add parquet report output support                                               

workflows/dia.nf

  • Add diann_report_parquet to emit outputs
  • Include FINAL_QUANTIFICATION.out.report_parquet in outputs
+7/-6     
quantms.nf
Switch to parquet format for DIA results                                 

workflows/quantms.nf

  • Replace DIA.out.final_result with DIA.out.diann_report_parquet
  • Update pipeline results mixing for new parquet format
+1/-1     

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@qodo-code-review
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Logic Change

The replacement of DIA.out.final_result with DIA.out.diann_report_parquet changes the pipeline output behavior. Need to verify this substitution is intentional and doesn't break downstream processing that might expect the original final_result format.

ch_pipeline_results = ch_pipeline_results.mix(DIA.out.diann_report_parquet)
ch_msstats_in = ch_msstats_in.mix(DIA.out.msstats_in)
Missing Output

The removal of the optional plots output channel may break existing workflows or scripts that depend on plot generation. Verify this removal aligns with the disabled plot exports configuration.

output:
path "*.html", emit: ch_pmultiqc_report
path "*.db", optional: true, emit: ch_pmultiqc_db
path "versions.yml", emit: versions
path "*_data", emit: data

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jul 24, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@ypriverol ypriverol changed the title support pmultiqc 0.0.30 support pmultiqc 0.0.31 Jul 24, 2025
@ypriverol ypriverol self-requested a review July 24, 2025 16:57
@ypriverol ypriverol merged commit acd056e into bigbio:dev Jul 24, 2025
82 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants